Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmptyCatchBlock change property types to Regexp #6455

Closed
Vampire opened this issue Feb 22, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@Vampire
Copy link
Contributor

commented Feb 22, 2019

The EmptyCatchBlock check documentation states that both properties are of type String, shouldn't this be Regular Expression?

https://checkstyle.org/config_blocks.html#EmptyCatchBlock

@rnveach

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

I agree with this.
The setters are String and that is why our documentation validator didn't pick this up.

public void setExceptionVariableName(String exceptionVariableName) {

@romani

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

Let's consider this issue as not a breaking changes,. Sonar plugin already treat such fields as regexp https://github.com/checkstyle/sonar-checkstyle/blob/4ee83573f003aa889f1e745cc27692f1e1048c12/checkstyle-sonar-plugin/src/main/resources/org/sonar/plugins/checkstyle/rules.xml#L2009
Probably all other also treated it as regexp, as default value were regexp style.

romani added a commit that referenced this issue Mar 4, 2019

@romani romani added the miscellaneous label Mar 4, 2019

@romani romani changed the title EmptyCatchBlock property types EmptyCatchBlock change property types to Regexp Mar 4, 2019

@romani romani added this to the 8.19 milestone Mar 4, 2019

@romani

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

Fix is merged

@romani romani closed this Mar 4, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.