Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PARAMETER_DEF from AnnotationLocation #6462

Closed
Vampire opened this issue Feb 23, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@Vampire
Copy link
Contributor

commented Feb 23, 2019

With the reasoning from #6416:

Quote from @romani:

All that tokens are not related to original idea of Check Check enforce to locate annotations immediately after documentation block and before target element, annotation should be located on separate line from target element. ... attention to documentation block.
Line wrapping that is possible with annotation usage should be covered by some other Check, I am not ready even tell about possible design for new Check .... live/users will show us what might be valuable in such validations.

PARAMETER_DEF should not be supported in AnnotationLocation check as parameters has no documentation and this Check is mostly for targets with javadocs. If somebody need to validate location of annotation in parameters - new Check need to be created.

This would also simplify the implementation, because parameters are specially treated anyway, having a single annotation with or without parameters on the same line with the parameter is always allowed though the documentation does not indicate this. This special treatment can also be removed.

If the PARAMETER_DEF handling stays, then at least the documentation should be updated to describe the special treatment of parameters for which only a small subset like multiple annotations on the same line are checked.

@romani romani added the approved label Mar 3, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Mar 8, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Mar 8, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Mar 10, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Mar 11, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Mar 18, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 10, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 10, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 10, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 11, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 11, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 16, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue May 2, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue May 3, 2019

@romani romani closed this in #6653 May 11, 2019

romani added a commit that referenced this issue May 11, 2019

@romani romani added this to the 8.21 milestone May 11, 2019

@romani

This comment has been minimized.

Copy link
Member

commented May 11, 2019

fix is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.