Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in docs of VisibilityModifier #6468

Closed
Vampire opened this issue Feb 24, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@Vampire
Copy link
Contributor

commented Feb 24, 2019

Docs say
Rationale: Forcing all fields of class to have private modified by default is good in most cases
should probably be
Rationale: Forcing all fields of class to have private modifier by default is good in most cases

@rnveach

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

modified => modifier
It's hard to see the exact difference in the first post.

@romani romani closed this in #6523 Mar 8, 2019

romani added a commit that referenced this issue Mar 8, 2019

@romani romani added the miscellaneous label Mar 8, 2019

@romani romani added this to the 8.19 milestone Mar 8, 2019

@romani

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

Fix is merged

@romani romani reopened this Mar 8, 2019

@romani romani closed this Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.