Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultipleVariableDeclarations missing from sun style #6490

Closed
Vampire opened this issue Feb 27, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@Vampire
Copy link
Contributor

commented Feb 27, 2019

The rational of the check says the sun style demands this, but it is not part of the sun checks XML.

https://checkstyle.org/config_coding.html#MultipleVariableDeclarations

@romani

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

https://checkstyle.org/sun_style.html this page is empty, because style guide is not properly created.
Sun config is seriously in unclear state.

One day we will find contributor to make like https://checkstyle.org/google_style.html , but this is a big project https://github.com/checkstyle/checkstyle/wiki/Checkstyle-GSoC-2019-Project-Ideas#project-name-sun-and-open-jdk-code-convention-coverage

@romani romani added the approved label Mar 3, 2019

@Vampire

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

Did you maybe misunderstand me?
Because I cannot relate your comment to my report @romani.
The rationale of the check says that the sun style demands what this check validates.
But the sun_checks.xml file does not include this check which is what I reported.

@rnveach

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

@Vampire Our sun and google configuration files are validated against the written guides from sun and google respectively. We create a table to show what line of text in the guide related to the check we have setup and configured to prove we follow the guide.

We already have a complete mapping for google:
http://checkstyle.sourceforge.net/google_style.html#Google_Coverage_table
http://checkstyle.sourceforge.net/reports/google-java-style-20170228.html

Sun's mapping is empty because no one has sat down and worked on it. Any text that says style is a demand of sun could be wrong.
https://checkstyle.org/sun_style.html#Sun_Coverage_table

@Vampire

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

Ah, now I understand what you mean, but actually the rational is correct:
grafik

Vampire added a commit to Vampire/checkstyle that referenced this issue Mar 12, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Mar 18, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 4, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 4, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 4, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 4, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 4, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 4, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 8, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 8, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 8, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 8, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 8, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 8, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 8, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 8, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 8, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Apr 8, 2019

rnveach added a commit that referenced this issue Apr 10, 2019

rnveach added a commit that referenced this issue Apr 10, 2019

@rnveach rnveach added this to the 8.20 milestone Apr 10, 2019

peterdemaeyer added a commit to peterdemaeyer/checkstyle that referenced this issue Apr 27, 2019

peterdemaeyer added a commit to peterdemaeyer/checkstyle that referenced this issue Apr 27, 2019

peterdemaeyer added a commit to peterdemaeyer/checkstyle that referenced this issue Apr 27, 2019

peterdemaeyer added a commit to peterdemaeyer/checkstyle that referenced this issue Apr 28, 2019

peterdemaeyer added a commit to peterdemaeyer/checkstyle that referenced this issue Apr 28, 2019

peterdemaeyer added a commit to peterdemaeyer/checkstyle that referenced this issue Apr 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.