Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong JavaDoc example for NestedForDepthCheck #6491

Closed
Vampire opened this issue Feb 27, 2019 · 7 comments

Comments

Projects
None yet
3 participants
@Vampire
Copy link
Contributor

commented Feb 27, 2019

NestedForDepthCheck JavaDoc shows an example for CatchWithLostStackCheck

@rnveach

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

@Vampire for small little corrections like this you don't need to create an issue. Just make a PR and prefix it with minor: or doc: .

@Vampire

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

Well, for me it is currently easier to create a ticket, so "just" means ticket.
I don't even have a checkstyle clone right now.
Just reading the documentation in the web and if unclear the JavaDoc or source in the IDE, but just from dependency, not from checked out code.

@rnveach

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

It may be easier to create an issue but it doesn't guarantee someone will work on it. We already have a backlog of 300+ approved issues and 200+ other issues that we are trying to make our way through. We don't have a lot of community assistance in fixing these issues so they just sit dormant for a long time. We would also appreciate it if you could help fix some of the minor things you are finding to help make a contribution to the project.

@romani

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

I don't even have a checkstyle clone right now.

You can search a string in our github repo, change, file, GitHub will do fork and PR for you.

@romani romani added the approved label Mar 3, 2019

@Vampire

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

I know, thanks. But this is one of the worst features of GitHub imho and I will never use it. :-)

Vampire added a commit to Vampire/checkstyle that referenced this issue Mar 12, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Mar 12, 2019

Vampire added a commit to Vampire/checkstyle that referenced this issue Mar 12, 2019

@romani romani closed this in #6566 Mar 14, 2019

romani added a commit that referenced this issue Mar 14, 2019

@romani romani added this to the 8.19 milestone Mar 14, 2019

@romani

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

Fix is merged

@romani romani reopened this Mar 14, 2019

@rnveach

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

@romani Did you accidentally re-open this or was there a reason?

@romani romani closed this Mar 16, 2019

Vantuz added a commit to Vantuz/checkstyle that referenced this issue Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.