Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hashCode and equals methods from FilterSet #6494

Closed
rnveach opened this issue Mar 3, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@rnveach
Copy link
Member

commented Mar 3, 2019

Identified at #4734 (comment) ,

FilterSet should remove hashCode and equals methods as it is not immutable and we don't care about order. It is not immutable right now since it has a removeFilter method. Checker is the only class that uses this method, and it doesn't use it directly except in a test. It is just a public method anyone can use it if they use the direct class. It is not supported by RootModule interface.

With such override, user can put object to map, changes object, try to find the same object in map, got nothing. But this class is API, it has to be done with breacking compatibility label.

@romani

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

Fix is merged

@romani romani closed this Mar 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.