Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all FilterElements immutable #6496

Closed
rnveach opened this issue Mar 3, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@rnveach
Copy link
Member

commented Mar 3, 2019

Identified when working on #4734 ,

Not all FilterElements are immutable.
CsvFilterElement has an add method and could be called if the instance of the class was leaked or maintained elsewhere.

We should verify all FilterElements are immutable and if not examine why they can't be and ensure other immutable classes aren't affected by them being mutable.
If a FilterElement is made or is immutable, we should make it have equals/hashCode methods if it doesn't already.

@romani romani added the approved label Mar 3, 2019

rnveach added a commit to rnveach/checkstyle that referenced this issue Mar 3, 2019

rnveach added a commit that referenced this issue Mar 3, 2019

@rnveach rnveach added this to the 8.19 milestone Mar 3, 2019

@rnveach

This comment has been minimized.

Copy link
Member Author

commented Mar 3, 2019

Fix was merged.

@rnveach rnveach closed this Mar 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.