Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude module-info.java from Google and Sun configurations #6570

Closed
mwkroening opened this issue Mar 14, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@mwkroening
Copy link
Contributor

commented Mar 14, 2019

It would be helpful to exclude the module-info.java (Reference) from the google_checks.xml and sun_checks.xml.

That way these configurations would work with modular projects out of the box.

@romani

This comment has been minimized.

Copy link
Member

commented Mar 16, 2019

make sense, please provide PR.

@romani romani added the approved label Mar 16, 2019

@romani romani changed the title Exclude module-info.java example configurations Exclude module-info.java from Google and Sun configurations Mar 16, 2019

mwkroening added a commit to mwkroening/checkstyle that referenced this issue Mar 17, 2019

mwkroening added a commit to mwkroening/checkstyle that referenced this issue Mar 18, 2019

mwkroening added a commit to mwkroening/checkstyle that referenced this issue Mar 19, 2019

mwkroening added a commit to mwkroening/checkstyle that referenced this issue Mar 20, 2019

rnveach added a commit that referenced this issue Mar 20, 2019

@rnveach

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

Fix was merged

@rnveach rnveach closed this Mar 20, 2019

@rnveach rnveach added this to the 8.19 milestone Mar 20, 2019

Vantuz added a commit to Vantuz/checkstyle that referenced this issue Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.