Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of antlr specific methods from our checks #6624

Closed
rnveach opened this issue Apr 3, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@rnveach
Copy link
Member

commented Apr 3, 2019

This is in support of issue #3817 .

We should remove uses of any ANTLR specific method and uses the DetailAST directly instead. These are methods that we didn't implement and take an AST (not DetailAST). They need to be removed as we can't change the method parameter of a method we are overriding and we want to remove ANTLR classes from the API package. It is better we use our own implementation instead of one that we don't control and don't know for sure what it does.

They are only 2 of these methods, so it is not a big loss in terms of compatibility.

@rnveach rnveach added the approved label Apr 3, 2019

@rnveach

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

One not assigned to this issue was completed at #6617 .
The last method will be completed at #6623 .

@romani

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

Fix is merged

@romani romani closed this Apr 3, 2019

@romani romani added this to the 8.20 milestone Apr 3, 2019

@rnveach

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

I am re-opening this to fix regresion. See #6623 (comment)

@rnveach rnveach reopened this Apr 3, 2019

Vantuz added a commit to Vantuz/checkstyle that referenced this issue Apr 3, 2019

@rnveach

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

Re-closing as regression changes to VariableDeclarationUsage look valid.

@rnveach rnveach closed this Apr 3, 2019

peterdemaeyer added a commit to peterdemaeyer/checkstyle that referenced this issue Apr 27, 2019

peterdemaeyer added a commit to peterdemaeyer/checkstyle that referenced this issue Apr 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.