Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new check: MissingJavadocPackageCheck #6705

Closed
rnveach opened this issue Apr 29, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@rnveach
Copy link
Member

commented Apr 29, 2019

Split from #5411 ,

We should create a new check for missing javadocs on package-info.java files.

@rnveach

This comment has been minimized.

Copy link
Member Author

commented Apr 29, 2019

@romani @pbludov Could naming of this check cause confusion with JavadocPackage?
http://checkstyle.sourceforge.net/config_javadoc.html#JavadocPackage

Current check ensures package-info.java file exists. New check will ensure package-info.java has a javadoc.

@pbludov

This comment has been minimized.

Copy link
Collaborator

commented May 5, 2019

Could naming of this check cause confusion with JavadocPackage?

Yes, the existing check's name is not clear, but this can not be changed.
I like the name of the new check.

strkkk added a commit to strkkk/checkstyle that referenced this issue Jun 3, 2019

strkkk added a commit to strkkk/checkstyle that referenced this issue Jun 3, 2019

strkkk added a commit to strkkk/checkstyle that referenced this issue Jun 4, 2019

strkkk added a commit to strkkk/checkstyle that referenced this issue Jun 4, 2019

strkkk added a commit to strkkk/checkstyle that referenced this issue Jun 4, 2019

strkkk added a commit to strkkk/checkstyle that referenced this issue Jun 4, 2019

strkkk added a commit to strkkk/checkstyle that referenced this issue Jun 4, 2019

strkkk added a commit to strkkk/checkstyle that referenced this issue Jun 4, 2019

strkkk added a commit to strkkk/checkstyle that referenced this issue Jun 13, 2019

strkkk added a commit to strkkk/checkstyle that referenced this issue Jun 13, 2019

strkkk added a commit to strkkk/checkstyle that referenced this issue Jun 14, 2019

strkkk added a commit to strkkk/checkstyle that referenced this issue Jun 17, 2019

strkkk added a commit to strkkk/checkstyle that referenced this issue Jun 18, 2019

romani added a commit that referenced this issue Jun 18, 2019

@romani romani added this to the 8.22 milestone Jun 18, 2019

@romani

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

Fix is merged

@romani romani closed this Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.