Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit xdoc Properties subsection to one table #6800

Closed
pbludov opened this issue Jun 3, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@pbludov
Copy link
Collaborator

commented Jun 3, 2019

From comment #6788 (review)

The properties section has a special purpose: the properties table.
Everything else should be moved to Nodes or Description.

The test XdocsPagesTest#validatePropertySection should verify this limit.

@rnveach

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

I couldn't find it but there is an issue somewhere about creating a new section in the check/filter for external configuration files like this.

Were you able to find this issue before creating this one?

@romani romani added the approved label Jun 4, 2019

@romani

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Approved. Even we find another issue, it will not block this issue, we can update doc in few steps

pbludov added a commit to pbludov/checkstyle that referenced this issue Jun 7, 2019

pbludov added a commit to pbludov/checkstyle that referenced this issue Jun 7, 2019

pbludov added a commit to pbludov/checkstyle that referenced this issue Jun 8, 2019

romani added a commit that referenced this issue Jun 12, 2019

@romani romani added this to the 8.22 milestone Jun 12, 2019

@romani

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

fix is merged.

@romani romani closed this Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.