Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppression documentation links to old DTDs #6804

Closed
Bananeweizen opened this issue Jun 5, 2019 · 10 comments

Comments

Projects
None yet
3 participants
@Bananeweizen
Copy link
Contributor

commented Jun 5, 2019

The user documentation at http://checkstyle.sourceforge.net/config_filters.html#SuppressionFilter contains 2 links to the suppression XML DTD. Both of those go to the no longer existing Sourceforge DTDs and need to be updated to point to https://checkstyle.org/dtds/suppressions_1_2.dtd instead

@rnveach

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

I did a search and that file didn't show up.
https://github.com/checkstyle/checkstyle/search?q=%22checkstyle.sourceforge.net%22&unscoped_q=%22checkstyle.sourceforge.net%22
Looks like we should update these areas to remove the old domain.

The user documentation at http://checkstyle.sourceforge.net/config_filters.html#SuppressionFilter contains 2 links to the suppression XML DTD

The issue is probably you are still using the outdated link and the links we have on our pages are relative links and leave out the domain. If you use https://checkstyle.org/config_filters.html#SuppressionFilter instead, you shouldn't find any bad links.
Example:

a <a href="dtds/suppressions_1_2.dtd"><em>suppressions XML

@Bananeweizen

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

Would it be possible to just delete the complete documentation at sourceforge then? I was coming from a websearch, namely https://duckduckgo.com/?q=checkstyle+suppression&t=ffab&ia=web, and the sourceforge result is above the github result unfortunately.

@rnveach

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

@romani Is it possible to verify the domain being requested and force people to the new location?

@romani

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

Would it be possible to just delete the complete documentation at sourceforge then?

We can, I just never had a time to think about it. Script on how I do copy of site from GitHub.io to sourceforge is at https://github.com/checkstyle/checkstyle/blob/master/.ci/copy-site-to-sourceforge.sh , we need to figure out how to make redirect to org site for all except for old sites (archive) and project reports. Apache http config should help us, but we need make it work.
Sourceforge is well know site, that is linked for many years on all forums, stack overflow, ... . We need to slowly migrate users.

For dtds we probably can search-replace to org site in copy script, or provide Apache redirect config for sourceforge dtds folder to org web site

@romani romani added the approved label Jun 16, 2019

@romani

This comment has been minimized.

Copy link
Member

commented Jun 16, 2019

I failed to make redirection on sourceforge to https website,
I created a ticket for support to help - https://sourceforge.net/p/forge/site-support/19520/

@romani

This comment has been minimized.

romani added a commit that referenced this issue Jun 18, 2019

romani added a commit that referenced this issue Jun 18, 2019

@romani

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

support ticket that web site is still on http - https://sourceforge.net/p/forge/site-support/19530/

@romani

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

http://checkstyle.sourceforge.net is now redirecting to https://checkstyle.sourceforge.io .
We do not have non secure websites anymore.

@romani

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

all old version sub sites were updated to redirect dtd to checkstyle.org:

[romanivanov@shell-23001 checkstyle]$ cp htdocs/.htaccess htdocs-version/htdocs-5.5
....
[romanivanov@shell-23001 checkstyle]$ cp htdocs/.htaccess htdocs-version/htdocs-8.9
[romanivanov@shell-23001 checkstyle]$ find htdocs-version/ -name .htaccess -exec chmod o+r {} \;
[romanivanov@shell-23001 checkstyle]$ find htdocs-version/ -name .htaccess -exec ls -l {} \;
[romanivanov@shell-23001 checkstyle]$ cat htdocs/.htaccess 
Redirect 301 "/dtds" "https://checkstyle.org/dtds"
RedirectMatch 301 "/version/.*/dtds/(.*)" "https://checkstyle.org/dtds/$1"

romani added a commit that referenced this issue Jun 22, 2019

romani added a commit that referenced this issue Jun 22, 2019

romani added a commit that referenced this issue Jun 22, 2019

@rnveach rnveach added this to the 8.22 milestone Jun 22, 2019

romani added a commit that referenced this issue Jun 22, 2019

@romani

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

All fixes are merged and applied to web sites

@romani romani closed this Jun 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.