Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javadoc error in NeedBracesCheck.java #6948

Closed
romani opened this issue Aug 6, 2019 · 5 comments

Comments

@romani
Copy link
Member

commented Aug 6, 2019

build failure https://travis-ci.org/checkstyle/checkstyle/jobs/568596932#L3215 :

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  06:17 min
[INFO] Finished at: 2019-08-06T23:40:17Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on project checkstyle: Error generating maven-javadoc-plugin:3.1.0:javadoc report: 
[ERROR] Exit code: 1 - /home/travis/build/checkstyle/checkstyle/src/main/java/com/puppycrawl/
tools/checkstyle/checks/blocks/NeedBracesCheck.java:137: error: bad use of '>'
[ERROR]  * allowedFuture.addCallback(result -> assertEquals("Invalid response",
[ERROR]                                      ^
[ERROR] /home/travis/build/checkstyle/checkstyle/src/main/java/com/puppycrawl/tools/
checkstyle/checks/blocks/NeedBracesCheck.java:139: error: bad use of '>'
[ERROR]  *   ex -> fail(ex.getMessage())); // OK
[ERROR]          ^
[ERROR] /home/travis/build/checkstyle/checkstyle/src/main/java/com/puppycrawl/tools
/checkstyle/checks/blocks/NeedBracesCheck.java:141: error: bad use of '>'
[ERROR]  * allowedFuture.addCallback(result -> {
[ERROR]                                      ^
[ERROR] /home/travis/build/checkstyle/checkstyle/src/main/java/com/puppycrawl/tools/
checkstyle/checks/blocks/NeedBracesCheck.java:145: error: bad use of '>'
[ERROR]  *   ex -> fail(ex.getMessage()));
[ERROR]          ^
[ERROR] /home/travis/build/checkstyle/checkstyle/src/main/java/com/puppycrawl/tools/
checkstyle/checks/javadoc/AtclauseOrderCheck.java:44: error: element not closed: ul
[ERROR]  * <ul>
[ERROR]    ^
[ERROR]

errors:

[ERROR] /home/travis/build/checkstyle/checkstyle/src/main/java/com/puppycrawl/tools/
checkstyle/checks/javadoc/AtclauseOrderCheck.java:68: error: unterminated inline tag
[ERROR]  * Default value is {@code @author, @deprecated, @exception, @param, @return,
[ERROR]                     ^
[ERROR] /home/travis/build/checkstyle/checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AtclauseOrderCheck.java:69: error: unexpected content
[ERROR]  * @see, @serial, @serialData, @serialField, @since, @throws, @version}.
[ERROR]    ^

will be fixed in #6947

@romani

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

@strkkk , please help to resolved.
caused by your commit - 58513c6

@romani romani added the approved label Aug 6, 2019

esilkensen added a commit to esilkensen/checkstyle that referenced this issue Aug 7, 2019
@esilkensen

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

@romani @strkkk I opened PR #6953

esilkensen added a commit to esilkensen/checkstyle that referenced this issue Aug 7, 2019
romani added a commit that referenced this issue Aug 7, 2019
@esilkensen

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

Should this issue and #6947 have a bug label?

It looks like the only error CI errors on the most recent master build were (https://travis-ci.org/checkstyle/checkstyle/jobs/568825112#L583)

[ERROR] Issue #6947 does not have breaking compatibility, bug, miscellaneous, new feature, new module label!
[ERROR] Issue #6948 does not have breaking compatibility, bug, miscellaneous, new feature, new module label!

Generation ends with 2 errors.

@romani romani added the miscellaneous label Aug 7, 2019

@romani

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

My bad, I set labels now

@romani romani added this to the 8.24 milestone Aug 7, 2019

@romani

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

fix is merged

@romani romani closed this Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.