After migration to junit5 build output become to have output

[romani]

problem can be seen at https://travis-ci.org/checkstyle/checkstyle/jobs/626861728#L1131

Example:

[INFO] Running com.puppycrawl.tools.checkstyle.JavadocPropertiesGeneratorTest
Missing required options [--destfile=<outputFile>, params[0]=<inputFile>]
Usage: java com.puppycrawl.tools.checkstyle.JavadocPropertiesGenerator [-hV]
       --destfile=<outputFile> <inputFile>
      <inputFile>   The input file.
      --destfile=<outputFile>
                    The output file.
  -h, --help        Show this help message and exit.
  -V, --version     Print version information and exit.
Missing required parameter: <inputFile>
Usage: java com.puppycrawl.tools.checkstyle.JavadocPropertiesGenerator [-hV]
       --destfile=<outputFile> <inputFile>
      <inputFile>   The input file.
      --destfile=<outputFile>
                    The output file.
  -h, --help        Show this help message and exit.
  -V, --version     Print version information and exit.
Usage: java com.puppycrawl.tools.checkstyle.JavadocPropertiesGenerator [-hV]
       --destfile=<outputFile> <inputFile>
      <inputFile>   The input file.
      --destfile=<outputFile>
                    The output file.
  -h, --help        Show this help message and exit.
  -V, --version     Print version information and exit.
Missing required option '--destfile=<outputFile>'
Usage: java com.puppycrawl.tools.checkstyle.JavadocPropertiesGenerator [-hV]
       --destfile=<outputFile> <inputFile>
      <inputFile>   The input file.
      --destfile=<outputFile>
                    The output file.
  -h, --help        Show this help message and exit.
  -V, --version     Print version information and exit.

but there are more out and even exception output.

Expected: UT should produce no output to plugin, build log should be clean from any unrelated information (as it was before)
it is not first time to come to such situation .... is there a way to fail build if some output is leaked ?

[romani]

@pbludov , please address.

[pbludov]

This is the limitation of junit5-system-extensions. I created issue itsallcode/junit5-system-extensions#16

[romani]

Hey, junit5 creates more problems than it being benefits

[romani]

Does it make sense to revert MainTest till issue is resolved?
I think we have no problems to mix junit5 and junit4.

[pbludov]

Does it make sense to revert MainTest till issue is resolved?
I think we have no problems to mix junit5 and junit4.

Let's wait for an answer from junit5-system-extensions team. If this is a difficult task, then commit 2e8ddda for MainTest and JavadocPropertiesGeneratorTest should be reverted.

[rnveach]

Fix was merged