-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method hasChildren to DetailAST #7487
Comments
I am ok to add this methood. |
@romani I was ok with it until I saw the default method in the interface. I personally would just prefer to see the implementation in the class. I am old school. |
ok, lets make method in interface as declaration. |
pbludov
added a commit
to pbludov/checkstyle
that referenced
this issue
Jan 17, 2020
pbludov
added a commit
to pbludov/checkstyle
that referenced
this issue
Jan 17, 2020
pbludov
added a commit
to pbludov/checkstyle
that referenced
this issue
Jan 17, 2020
pbludov
added a commit
to pbludov/checkstyle
that referenced
this issue
Jan 17, 2020
pbludov
added a commit
to pbludov/checkstyle
that referenced
this issue
Jan 17, 2020
pbludov
added a commit
to pbludov/checkstyle
that referenced
this issue
Jan 17, 2020
pbludov
added a commit
to pbludov/checkstyle
that referenced
this issue
Jan 17, 2020
pbludov
added a commit
to pbludov/checkstyle
that referenced
this issue
Jan 20, 2020
pbludov
added a commit
to pbludov/checkstyle
that referenced
this issue
Jan 20, 2020
Started hcoles/pitest#725 for the Pitest issue. |
pbludov
added a commit
to pbludov/checkstyle
that referenced
this issue
Jan 25, 2020
pbludov
added a commit
to pbludov/checkstyle
that referenced
this issue
Jan 25, 2020
pbludov
added a commit
to pbludov/checkstyle
that referenced
this issue
Jan 25, 2020
pbludov
added a commit
to pbludov/checkstyle
that referenced
this issue
Jan 25, 2020
pbludov
added a commit
to pbludov/checkstyle
that referenced
this issue
Jan 25, 2020
romani
pushed a commit
that referenced
this issue
Jan 26, 2020
romani
pushed a commit
that referenced
this issue
Jan 26, 2020
Fix is merged |
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From sevntu-checkstyle/sevntu.checkstyle#794 (comment)
The most common usage of the method getChildCount is to compare the count to zero. For example. This is not efficient nor readable. Both issues can be fixed by adding a new method to the
DetailAST
interface:The text was updated successfully, but these errors were encountered: