Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
deprecate Checker.setClassloader , replace with Checker.setClassLoader #922
Confusing to have methods com.puppycrawl.tools.checkstyle.Checker.setClassloader(ClassLoader) and com.puppycrawl.tools.checkstyle.TreeWalker.setClassLoader(ClassLoader) BAD_PRACTICE NM_CONFUSING 449-450 Low
That change will brake compatibility with checkstyle-maven-plugin, so it should be done only after plugin will switch to java7 version of checkstyle.
New method with correct name was added, old method is deprecated, will be removed as soon as maven plugin will switch to latest versions (that use java7).
added a commit
May 15, 2015
we can remove method as soon as Issue MCHECKSTYLE-293 - usage of Checker.setClassLoader method is fixed
maven checkstyle plugin is released as 2.17.
But it is still problematic to remove such method as most of integrations/plugins still use it and they are still on old versions of our library (good example is Sonar plugin, still 6.4.1, new method is introduced at 6.7).
So final removal of deprecated method should be done after some time.... lets make in half of the year (6 checkstyle releases) - at May 15 2016, 1 year after method is marked as deprecated (12 checkstyle releases).