New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate Checker.setClassloader , replace with Checker.setClassLoader #922

Closed
romani opened this Issue Apr 11, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@romani
Member

romani commented Apr 11, 2015

Confusing to have methods com.puppycrawl.tools.checkstyle.Checker.setClassloader(ClassLoader) and com.puppycrawl.tools.checkstyle.TreeWalker.setClassLoader(ClassLoader) BAD_PRACTICE NM_CONFUSING 449-450 Low

That change will brake compatibility with checkstyle-maven-plugin, so it should be done only after plugin will switch to java7 version of checkstyle.

New method with correct name was added, old method is deprecated, will be removed as soon as maven plugin will switch to latest versions (that use java7).

@romani

This comment has been minimized.

Show comment
Hide comment
Member

romani commented May 15, 2015

we can remove method as soon as Issue MCHECKSTYLE-293 - usage of Checker.setClassLoader method is fixed

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Oct 31, 2015

Member

maven checkstyle plugin is released as 2.17.

But it is still problematic to remove such method as most of integrations/plugins still use it and they are still on old versions of our library (good example is Sonar plugin, still 6.4.1, new method is introduced at 6.7).

So final removal of deprecated method should be done after some time.... lets make in half of the year (6 checkstyle releases) - at May 15 2016, 1 year after method is marked as deprecated (12 checkstyle releases).

Member

romani commented Oct 31, 2015

maven checkstyle plugin is released as 2.17.

But it is still problematic to remove such method as most of integrations/plugins still use it and they are still on old versions of our library (good example is Sonar plugin, still 6.4.1, new method is introduced at 6.7).

So final removal of deprecated method should be done after some time.... lets make in half of the year (6 checkstyle releases) - at May 15 2016, 1 year after method is marked as deprecated (12 checkstyle releases).

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Nov 2, 2016

Member

@romani This looks like a Checkstyle 8 candidate. We are pass May 2016.

Member

rnveach commented Nov 2, 2016

@romani This looks like a Checkstyle 8 candidate. We are pass May 2016.

romani added a commit that referenced this issue Jul 1, 2017

romani added a commit that referenced this issue Jul 1, 2017

@romani romani added this to the 8.0 milestone Jul 1, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jul 1, 2017

Member

fix is merged

Member

romani commented Jul 1, 2017

fix is merged

@romani romani closed this Jul 1, 2017

@romani romani changed the title from Findbugs violation: Checker.setClassloader should be Checker.setClassLoader to deprecate Checker.setClassloader , replace with Checker.setClassLoader Jul 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment