Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update AbstractClassNameCheckTest.java to use unique Input file in each test method #9746

Closed
Ritik2604 opened this issue Mar 28, 2021 · 3 comments
Closed

update AbstractClassNameCheckTest.java to use unique Input file in each test method #9746

Ritik2604 opened this issue Mar 28, 2021 · 3 comments
Labels
approved good second issue miscellaneous
Milestone
8.42

Comments

@Ritik2604
Copy link
Contributor

AbstractClassNameCheckTest.java file reuse some Input files least time in a few different test method.
Expected: each test method in Test class use its own Input file and do not share it with any other test method.

more details - https://github.com/checkstyle/checkstyle/wiki/Good-practice-on-how-to-create-Input-files-for-tests
@Ritik2604
Copy link
Contributor Author

I am on it.

@Ritik2604
Copy link
Contributor Author

This issue was opened as a GSoC 2nd issue. @romani Could you please approve it at your convenience?

Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Mar 29, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest.java use uni…
59164c8 
…que Input file in each test method
@Ritik2604 Ritik2604 mentioned this issue Mar 29, 2021
Closed
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Mar 30, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest.java use uni…
e107c5c 
…que Input file in each test method
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Mar 30, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest.java use uni…
916c4d2 
…que Input file in each test method
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Mar 30, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest.java use uni…
a1d07dd 
…que Input file in each test method
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Mar 30, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest.java use uni…
034ee7d 
…que Input file in each test method

Issue checkstyle#9746: update AbstractClassNameCheckTest.java use unique Input file in each test method

Issue checkstyle#9746: update AbstractClassNameCheckTest.java use unique Input file in each test method

Issue checkstyle#9746: update AbstractClassNameCheckTest.java use unique Input file in each test method
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Mar 30, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest
ae083f6
Ritik2604 pushed a commit to Ritik2604/checkstyle that referenced this issue Mar 30, 2021
@AkMo3 @Ritik2604
This is a combination of 2 commits.
88c841a 
Issue checkstyle#9531: update WriteTagCheckTest to use unique Input file

Issue checkstyle#9746: update AbstractClassNameCheckTest Inp
Issue checkstyle#9746: update AbstractClassNameCheckTest Inp

Issue checkstyle#9746: update AbstractClassNameCheckTest Inp

Issue checkstyle#9746: update AbstractClassNameCheckTest Inp
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Mar 30, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest
fabd3fc
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Mar 30, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest
8752783
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Mar 30, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest
6a7c68d
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Mar 30, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest
13ada0c
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Mar 30, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest
c860ea7
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Mar 30, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest
a94655a
@Ritik2604 Ritik2604 mentioned this issue Mar 30, 2021
Closed
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Mar 30, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest
c9aa8f7
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Mar 30, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest
f0e1996 
Issue checkstyle#9746: update AbstractClassNameCheckTest
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Mar 30, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest
ef9234c
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Mar 30, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest
a73e498 
Issue checkstyle#9746: update AbstractClassNameCheckTest
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Mar 30, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest
2b62c61
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Mar 30, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest
dc109f6
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Mar 31, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractJava
61d219b
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Apr 1, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheck
5225c71
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Apr 1, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest
fac38d0
@Ritik2604 Ritik2604 mentioned this issue Apr 1, 2021
Closed
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Apr 1, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest
8e37116
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Apr 1, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest
2ebc4a4
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Apr 1, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest
588c6aa
@Ritik2604 Ritik2604 mentioned this issue Apr 1, 2021
Merged
romani pushed a commit that referenced this issue Apr 5, 2021
@Ritik2604 @romani
Issue #9746: update AbstractClassNameCheckTest
9d2f4dc
@romani romani added this to the 8.42 milestone Apr 5, 2021
@romani
Copy link
Member

romani commented Apr 5, 2021

merged

@romani romani closed this as completed Apr 5, 2021
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Apr 5, 2021
@Ritik2604
Issue checkstyle#9471: update example of TokenTypes.LITERAL_DEFAULT
a595547 
Issue checkstyle#9471: update example of TokenTypes.LITERAL_DEFAULT

Issue checkstyle#9746: update AbstractClassNameCheckTest

Issue checkstyle#9390: update example of AST for TokenTypes.ANNOTATION_ARRAY_INIT

Issue checkstyle#9471: update example of TokenTypes.LITERAL_DEFAULT
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Apr 5, 2021
@Ritik2604
Issue checkstyle#9746: update AbstractClassNameCheckTest
1fcdcec
AB-san pushed a commit to AB-san/checkstyle that referenced this issue Apr 7, 2021
@Ritik2604 @AB-san
Issue checkstyle#9746: update AbstractClassNameCheckTest
d9bccca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved good second issue miscellaneous
Projects
None yet
Milestone
8.42
2 participants
@romani @Ritik2604