Pull #3263: corrected alphabetical order of the checks #3263

Merged
merged 2 commits into from Jun 12, 2016

Conversation

Projects
None yet
4 participants
@f05fk
Contributor

f05fk commented Jun 10, 2016

The "Checks" page lists the available checks in alphabetical order and even says that it does. Therefore I corrected the order of some checks, because they have not been in the right place.

@f05fk f05fk changed the title from corrected alphabetical order of the checks to Pull #3263: corrected alphabetical order of the checks Jun 10, 2016

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jun 10, 2016

Current coverage is 100%

Merging #3263 into master will not change coverage

@@             master      #3263   diff @@
==========================================
  Files           276        276          
  Lines         13948      13978    +30   
  Methods           0          0          
  Messages          0          0          
  Branches       3236       3246    +10   
==========================================
+ Hits          13948      13978    +30   
  Misses            0          0          
  Partials          0          0          

Powered by Codecov. Last updated by ae254f7...aac3a2f

codecov-io commented Jun 10, 2016

Current coverage is 100%

Merging #3263 into master will not change coverage

@@             master      #3263   diff @@
==========================================
  Files           276        276          
  Lines         13948      13978    +30   
  Methods           0          0          
  Messages          0          0          
  Branches       3236       3246    +10   
==========================================
+ Hits          13948      13978    +30   
  Misses            0          0          
  Partials          0          0          

Powered by Codecov. Last updated by ae254f7...aac3a2f

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Jun 10, 2016

Member

@f05fk
When we sort checks on other pages, we sort them ignoring case. We should probably continue that type of sorting here.
See https://github.com/checkstyle/checkstyle/blob/master/src/test/java/com/puppycrawl/tools/checkstyle/internal/XDocsPagesTest.java#L283-L287

Here are some other changes based on that type of sorting:
JavaNCSS should come after JavadocVariable, NPathComplexity should come after NoWhitespaceBefore, NonEmptyAtclauseDescription should come after NoLineWrap (not NoWhitespaceBefore), TypeName should come after TypecastParenPad.

Member

rnveach commented Jun 10, 2016

@f05fk
When we sort checks on other pages, we sort them ignoring case. We should probably continue that type of sorting here.
See https://github.com/checkstyle/checkstyle/blob/master/src/test/java/com/puppycrawl/tools/checkstyle/internal/XDocsPagesTest.java#L283-L287

Here are some other changes based on that type of sorting:
JavaNCSS should come after JavadocVariable, NPathComplexity should come after NoWhitespaceBefore, NonEmptyAtclauseDescription should come after NoLineWrap (not NoWhitespaceBefore), TypeName should come after TypecastParenPad.

@f05fk

This comment has been minimized.

Show comment
Hide comment
@f05fk

f05fk Jun 11, 2016

Contributor

Ok. Good argument. I also find it more natural to sort case-insensitive but I tried to stick with the existing case-sensitive sorting in my first attempt. I'll apply the suggested changes.

Contributor

f05fk commented Jun 11, 2016

Ok. Good argument. I also find it more natural to sort case-insensitive but I tried to stick with the existing case-sensitive sorting in my first attempt. I'll apply the suggested changes.

@romani romani merged commit bca44e5 into checkstyle:master Jun 12, 2016

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codacy/pr Good work! The project quality is stable.
Details
codecov/project 100% (+0.00%) compared to ae254f7
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/teamcity Finished TeamCity Build Checkstyle :: IDEA Inspections Pull Request : Inspections total: 0, errors: 0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jun 12, 2016

Member

merged by web ui, commit message is "Pull #3263: corrected case-insensitive alphabetical order of the checks"

Member

romani commented Jun 12, 2016

merged by web ui, commit message is "Pull #3263: corrected case-insensitive alphabetical order of the checks"

@romani romani added this to the 7.0 milestone Jun 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment