Improve French translation for annotations warnings #3278

Merged
merged 1 commit into from Jun 16, 2016

Conversation

Projects
None yet
3 participants
@don-vip
Contributor

don-vip commented Jun 15, 2016

Pull #3278: improve French translation for annotations warnings

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jun 15, 2016

Current coverage is 100%

Merging #3278 into master will not change coverage

@@           master   #3278   diff @@
=====================================
  Files         276     276          
  Lines       13992   13992          
  Methods         0       0          
  Messages        0       0          
  Branches     3251    3251          
=====================================
  Hits        13992   13992          
  Misses          0       0          
  Partials        0       0          

Powered by Codecov. Last updated by bfb13d4...8c77635

codecov-io commented Jun 15, 2016

Current coverage is 100%

Merging #3278 into master will not change coverage

@@           master   #3278   diff @@
=====================================
  Files         276     276          
  Lines       13992   13992          
  Methods         0       0          
  Messages        0       0          
  Branches     3251    3251          
=====================================
  Hits        13992   13992          
  Misses          0       0          
  Partials        0       0          

Powered by Codecov. Last updated by bfb13d4...8c77635

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jun 16, 2016

Member

Yes, non of mainteners know french, but we had a lot f missed translations that needed to be filled. Google translate was a solution.

Thanks for update, please change commit message to reference PR number like "Pull #3278: ..." and push to your branch with force option. We have strict rules for commit messages as they are used in release notes generation

Member

romani commented Jun 16, 2016

Yes, non of mainteners know french, but we had a lot f missed translations that needed to be filled. Google translate was a solution.

Thanks for update, please change commit message to reference PR number like "Pull #3278: ..." and push to your branch with force option. We have strict rules for commit messages as they are used in release notes generation

@don-vip

This comment has been minimized.

Show comment
Hide comment
@don-vip

don-vip Jun 16, 2016

Contributor

Done :)

Contributor

don-vip commented Jun 16, 2016

Done :)

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jun 16, 2016

Member

CI is red , as commit message is not follow required format, please change commit message to be single line and start with "Pull #3278: "

Member

romani commented Jun 16, 2016

CI is red , as commit message is not follow required format, please change commit message to be single line and start with "Pull #3278: "

@don-vip don-vip changed the title from Fix French translation to Pull #3278: improve French translation for annotations warnings Jun 16, 2016

@don-vip don-vip changed the title from Pull #3278: improve French translation for annotations warnings to Improve French translation for annotations warnings Jun 16, 2016

@don-vip

This comment has been minimized.

Show comment
Hide comment
@don-vip

don-vip Jun 16, 2016

Contributor

Ok sorry, this time it should be OK.

Contributor

don-vip commented Jun 16, 2016

Ok sorry, this time it should be OK.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jun 16, 2016

Member

Travis build "NoExceptionTest - Checkstyle, sevntu-checkstyle" is expected for now.
Appveyor build is relaunched.

Member

romani commented Jun 16, 2016

Travis build "NoExceptionTest - Checkstyle, sevntu-checkstyle" is expected for now.
Appveyor build is relaunched.

@romani romani merged commit 6661579 into checkstyle:master Jun 16, 2016

3 of 5 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
codacy/pr Good work! The project quality is stable.
Details
continuous-integration/teamcity Finished TeamCity Build Checkstyle :: IDEA Inspections Pull Request : Inspections total: 0, errors: 0
Details
@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jun 16, 2016

Member

merged , thanks a lot !
You are welcome with other fixes.

Member

romani commented Jun 16, 2016

merged , thanks a lot !
You are welcome with other fixes.

@don-vip don-vip deleted the don-vip:patch-1 branch Jun 16, 2016

@don-vip

This comment has been minimized.

Show comment
Hide comment
@don-vip

don-vip Jun 16, 2016

Contributor

thank you :)

Contributor

don-vip commented Jun 16, 2016

thank you :)

@romani romani added this to the 7.0 milestone Jun 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment