Cut down on Checkstyle's dependencies on Guava #3293

Merged
merged 1 commit into from Jun 23, 2016

Conversation

Projects
None yet
3 participants
@MEZk
Contributor

MEZk commented Jun 20, 2016

#3293

Since now we use Java 1.8, it worth cutting down on Checkstyle's dependencies on Guava library:

  1. Guava's Optional replaced with Java's native.
  2. Guava's Predicate and Iterables should be replaced with Java's Predicate and streams. We cannot do this until we resolve or find workaround for Cobertura report generation problem on Java 1.8. (#3269 (comment), mojohaus/cobertura-maven-plugin#21)
  3. ...

P.S.
Teamcity's violations are not correct as java.util.Optional is not an unused import.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Jun 21, 2016

Member

@MEZk , please rebase on latest master to avoid Travis::sonar problem.
Please open issue on Teamcity and I am ok to suppress such validation in IntelijIdea inspections config.

Member

romani commented Jun 21, 2016

@MEZk , please rebase on latest master to avoid Travis::sonar problem.
Please open issue on Teamcity and I am ok to suppress such validation in IntelijIdea inspections config.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jun 23, 2016

Current coverage is 100%

Merging #3293 into master will not change coverage

@@           master   #3293   diff @@
=====================================
  Files         276     276          
  Lines       14015   14015          
  Methods         0       0          
  Messages        0       0          
  Branches     3264    3264          
=====================================
  Hits        14015   14015          
  Misses          0       0          
  Partials        0       0          

Powered by Codecov. Last updated by c156cf7...7d9a8fd

Current coverage is 100%

Merging #3293 into master will not change coverage

@@           master   #3293   diff @@
=====================================
  Files         276     276          
  Lines       14015   14015          
  Methods         0       0          
  Messages        0       0          
  Branches     3264    3264          
=====================================
  Hits        14015   14015          
  Misses          0       0          
  Partials        0       0          

Powered by Codecov. Last updated by c156cf7...7d9a8fd

@MEZk

This comment has been minimized.

Show comment
Hide comment
@MEZk

MEZk Jun 23, 2016

Contributor

@romani

please rebase on latest master to avoid Travis::sonar problem.

Done

Please open issue on Teamcity and I am ok to suppress such validation in IntelijIdea inspections config.

Strange but there are no violations now at TeamCity connected to Optional.

Contributor

MEZk commented Jun 23, 2016

@romani

please rebase on latest master to avoid Travis::sonar problem.

Done

Please open issue on Teamcity and I am ok to suppress such validation in IntelijIdea inspections config.

Strange but there are no violations now at TeamCity connected to Optional.

@romani romani merged commit eb5b977 into checkstyle:master Jun 23, 2016

5 of 6 checks passed

continuous-integration/teamcity Finished TeamCity Build Checkstyle :: IDEA Inspections Pull Request : Number of inspection errors 17 is 17 more than the provided threshol…
Details
ci/circleci Your tests passed on CircleCI!
Details
codacy/pr Good work! The project quality is stable.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
wercker/build Wercker pipeline passed
Details

@romani romani added this to the 7.0 milestone Jun 23, 2016

@MEZk MEZk deleted the MEZk:checkstyle-dependencies branch Jul 19, 2016

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Sep 7, 2016

Member

work will be continued at #3433

Member

romani commented Sep 7, 2016

work will be continued at #3433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment