New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3584: Deprecate 'url' property of ImportControlCheck #3599

Merged
merged 1 commit into from Nov 29, 2016

Conversation

Projects
None yet
2 participants
@jochenvdv
Contributor

jochenvdv commented Nov 29, 2016

Issue #3584

I wasn't sure about how to mark the property as deprecated in xdocs, so I put it in the description.

I think it would be nice if we could put it in the title of the property table as well but this would require a change in XDocsPagesTest.

For example:

<tr>
  <td>url (deprecated)</td>
  <td>
    URL of the file containing the import control configuration.
    This property is deprecated. Please use the file property to load configurations
    from URLs.
  </td>
  <td><a href="property_types.html#string">string</a></td>
  <td><code>null</code></td>
</tr>

Another option would be to give it a CSS class and use CSS to generate the (deprecated) after the property name.

If you like these ideas I can open an issue for this.

@romani romani merged commit a0b86b8 into checkstyle:master Nov 29, 2016

6 checks passed

IDEA Inspections Pull Request (Checkstyle) TeamCity build finished
Details
Shippable Run 324 status is SUCCESS.
Details
ci/circleci Your tests passed on CircleCI!
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jochenvdv jochenvdv deleted the jochenvdv:issue-3584 branch Jan 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment