New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new check to detect a certain annotation and field modifier #4118

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@liviutudor

The reason behind this is to prevent in some of the projects I work on in Netflix the usage of Governator's @Configuration annotation on final fields -- doing this has no effect (since the field is final) but misleads often the developer in thinking it works.
As such I have created a new check AvoidAnnotationCombinationCheck and it passes all tests bar one which from what I can see tests that the new error message I have introduced is translated in all languages. I speak English, Romanian and French so I could help with those but I certainly cannot do it to all the languages Checkstyle supports. As such I am looking for a bit of help here -- I couldn't find any mention of that anywhere in the docco? Once someone helps me with that then I can add a commit which contains all the translations and then the final test will pass.
If there is anything else I need to change also happy to do so.
Thanks,

import com.puppycrawl.tools.checkstyle.BaseCheckTestSupport;
import com.puppycrawl.tools.checkstyle.DefaultConfiguration;
import com.puppycrawl.tools.checkstyle.api.TokenTypes;
@Vladlis

This comment has been minimized.

Show comment
Hide comment
@Vladlis

Vladlis Mar 29, 2017

Member

@liviutudor , please read http://checkstyle.sourceforge.net/contributing.html#Introduction

ATTENTION: any new Check that you are going to introduce you need to contribute to our sanbox project sevntu.checkstyle. We are receiving only bug fixes for now to our main project, here is a reason.

Member

Vladlis commented Mar 29, 2017

@liviutudor , please read http://checkstyle.sourceforge.net/contributing.html#Introduction

ATTENTION: any new Check that you are going to introduce you need to contribute to our sanbox project sevntu.checkstyle. We are receiving only bug fixes for now to our main project, here is a reason.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Apr 3, 2017

Member

@liviutudor I am closing this.
Before any new check can begin a PR, we need an issue first and discuss reason for check and how it should be implemented and then approved.

Member

rnveach commented Apr 3, 2017

@liviutudor I am closing this.
Before any new check can begin a PR, we need an issue first and discuss reason for check and how it should be implemented and then approved.

@rnveach rnveach closed this Apr 3, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Apr 5, 2017

Member

@liviutudor , please cleate an issue, am about to remove moratorium but Check has be approved first. If maintainers be unsure about design or reason then Check should got sandbox project to get maturity

Member

romani commented Apr 5, 2017

@liviutudor , please cleate an issue, am about to remove moratorium but Check has be approved first. If maintainers be unsure about design or reason then Check should got sandbox project to get maturity

@liviutudor

This comment has been minimized.

Show comment
Hide comment
@liviutudor

liviutudor Apr 5, 2017

Hi @romani sorry for replying late to this I have been tied up with (other) work.
I will follow the workflow suggested and open an issue for this and go via the sandbox.
Thanks all for the feedback!

Hi @romani sorry for replying late to this I have been tied up with (other) work.
I will follow the workflow suggested and open an issue for this and go via the sandbox.
Thanks all for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment