Adding IDEA project files to gitignore and excluding them from checkstyle list #4209

Merged
merged 1 commit into from Apr 15, 2017

Conversation

Projects
None yet
4 participants
@timurt
Collaborator

timurt commented Apr 13, 2017

Intellij IDEA generates checkstyle.ipr and checkstyle.iws files which are not excluded from checkstyle list, that causes verification to be failed.

Files checkstyle.ipr and checkstyle.iws are not specified in gitignore file.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Apr 13, 2017

Member

This problem was identified at #4064 (comment) and #4064 (comment) .

@timurt
We generally like to have an issue associated with most PRs. Edit: I see romani requested it like this.
CI is also failing because of commit name.

Please append Pull #4209: to beginning of commit name.
Please also update first post to clearly specify the problem this PR is fixing.

Member

rnveach commented Apr 13, 2017

This problem was identified at #4064 (comment) and #4064 (comment) .

@timurt
We generally like to have an issue associated with most PRs. Edit: I see romani requested it like this.
CI is also failing because of commit name.

Please append Pull #4209: to beginning of commit name.
Please also update first post to clearly specify the problem this PR is fixing.

@rnveach rnveach requested a review from romani Apr 13, 2017

timurt pushed a commit to timurt/checkstyle that referenced this pull request Apr 13, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Apr 14, 2017

Member

@timurt Please rebase on latest master. We made other changes to the list in the pom.

Member

rnveach commented Apr 14, 2017

@timurt Please rebase on latest master. We made other changes to the list in the pom.

Tima
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Apr 15, 2017

Codecov Report

Merging #4209 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4209   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         283     283           
  Lines       14885   14885           
  Branches     3402    3402           
======================================
  Hits        14885   14885

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77251f0...bb9f0e1. Read the comment docs.

codecov-io commented Apr 15, 2017

Codecov Report

Merging #4209 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4209   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         283     283           
  Lines       14885   14885           
  Branches     3402    3402           
======================================
  Hits        14885   14885

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77251f0...bb9f0e1. Read the comment docs.

@timurt

This comment has been minimized.

Show comment
Hide comment
@timurt

timurt Apr 15, 2017

Collaborator

@rnveach rebased

Collaborator

timurt commented Apr 15, 2017

@rnveach rebased

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Apr 15, 2017

Member

@romani please review

Member

rnveach commented Apr 15, 2017

@romani please review

@romani romani merged commit 92c43f0 into checkstyle:master Apr 15, 2017

7 checks passed

IDEA Inspections Pull Request (Checkstyle) TeamCity build finished
Details
codacy/pr Good work! A positive pull request.
Details
codecov/patch Coverage not affected when comparing 77251f0...bb9f0e1
Details
codecov/project 100% remains the same compared to 77251f0
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
wercker/build Wercker pipeline passed
Details

@timurt timurt deleted the timurt:idea branch May 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment