New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull #4907: disallow java.util.Comparator in import-control #4907

Merged
merged 1 commit into from Aug 7, 2017

Conversation

Projects
None yet
4 participants
@Luolc
Contributor

Luolc commented Aug 7, 2017

As seen in #4899 (comment) , using the class java.util.Comparator causes cobertura to drop the entire class from the code coverage report. It's use should be avoided to prevent the issue from happening again.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 7, 2017

Codecov Report

Merging #4907 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4907   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         287     287           
  Lines       15488   15488           
  Branches     3518    3518           
======================================
  Hits        15488   15488

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16f91dd...eefdd1a. Read the comment docs.

codecov-io commented Aug 7, 2017

Codecov Report

Merging #4907 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4907   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         287     287           
  Lines       15488   15488           
  Branches     3518    3518           
======================================
  Hits        15488   15488

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16f91dd...eefdd1a. Read the comment docs.

@romani romani merged commit d573b26 into checkstyle:master Aug 7, 2017

7 of 8 checks passed

Shippable Run 4396 status is WAITING.
Details
IDEA Inspections Pull Request (Checkstyle) TeamCity build finished
Details
codecov/patch Coverage not affected when comparing 16f91dd...eefdd1a
Details
codecov/project 100% remains the same compared to 16f91dd
Details
continuous-integration/Distelli
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
wercker/build Wercker pipeline passed
Details
@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Aug 7, 2017

Member

@Luolc I updated your first post. Please be sure to include all information in first post as this is similar to an Issue and PR in one.
When people want to know the details of the commit, they will come here first.

Member

rnveach commented Aug 7, 2017

@Luolc I updated your first post. Please be sure to include all information in first post as this is similar to an Issue and PR in one.
When people want to know the details of the commit, they will come here first.

@Luolc Luolc deleted the Luolc:comparator branch Aug 7, 2017

@Luolc

This comment has been minimized.

Show comment
Hide comment
@Luolc

Luolc Aug 7, 2017

Contributor

@rnveach Got it.

Contributor

Luolc commented Aug 7, 2017

@rnveach Got it.

@romani romani added the miscellaneous label Aug 8, 2017

soon added a commit to soon/checkstyle that referenced this pull request Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment