New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4675: increased coverage of pitest-checks-misc to 96% #4990

Merged
merged 1 commit into from Aug 23, 2017

Conversation

Projects
None yet
3 participants
@Nimfadora
Contributor

Nimfadora commented Aug 22, 2017

Issue #4675

report before changes

pitest-checks-misc coverage by 3%
current threshold: 96%

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Aug 23, 2017

Member

@Nimfadora , sorry for late notification , but SuppressWarningsHolder will be eventually removed, see #4831 for details. It might be reasonable to suppress all methods in pitest config or any reflection/mock to easily cover it.
All XxxxxxxHolders are about to be removed, if any still stay we can exclude them from pitest coverage.

This PR is approved to be merged.

Member

romani commented Aug 23, 2017

@Nimfadora , sorry for late notification , but SuppressWarningsHolder will be eventually removed, see #4831 for details. It might be reasonable to suppress all methods in pitest config or any reflection/mock to easily cover it.
All XxxxxxxHolders are about to be removed, if any still stay we can exclude them from pitest coverage.

This PR is approved to be merged.

@romani

romani approved these changes Aug 23, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 23, 2017

Codecov Report

Merging #4990 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4990   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         291     291           
  Lines       15763   15760    -3     
  Branches     3561    3560    -1     
======================================
- Hits        15763   15760    -3
Impacted Files Coverage Δ
...heckstyle/checks/regexp/RegexpSinglelineCheck.java 100% <0%> (ø) ⬆️
...checkstyle/checks/regexp/RegexpMultilineCheck.java 100% <0%> (ø) ⬆️
...s/checkstyle/checks/regexp/SinglelineDetector.java 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7638c89...5857e43. Read the comment docs.

codecov-io commented Aug 23, 2017

Codecov Report

Merging #4990 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4990   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         291     291           
  Lines       15763   15760    -3     
  Branches     3561    3560    -1     
======================================
- Hits        15763   15760    -3
Impacted Files Coverage Δ
...heckstyle/checks/regexp/RegexpSinglelineCheck.java 100% <0%> (ø) ⬆️
...checkstyle/checks/regexp/RegexpMultilineCheck.java 100% <0%> (ø) ⬆️
...s/checkstyle/checks/regexp/SinglelineDetector.java 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7638c89...5857e43. Read the comment docs.

@romani romani merged commit 7b48869 into checkstyle:master Aug 23, 2017

9 checks passed

IDEA Inspections Pull Request (Checkstyle) TeamCity build finished
Details
Shippable Run 4666 status is SUCCESS.
Details
codacy/pr Good work! A positive pull request.
Details
codecov/patch Coverage not affected when comparing 7638c89...5857e43
Details
codecov/project 100% remains the same compared to 7638c89
Details
continuous-integration/Distelli
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
wercker/build Wercker pipeline passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment