New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull #5068: Fix order of message parameters in DE translation file #5068

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@akurth

akurth commented Sep 4, 2017

Number of allowed method parameters has been confused with number of actual method parameters, so that for a method with 50 parameters the German error message would be (analogously): "More than 50 parameters (found 9)." Fixed by switching ArgumentIndexes.

@akurth akurth changed the title from Pull #5066: Fix order of message parameters in DE translation file to Pull #5068: Fix order of message parameters in DE translation file Sep 4, 2017

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Sep 4, 2017

Member

@akurth you don't need to close and recreate a brand new PR to make changes.
All you need to do is amend your previous commit and force push it to the server and github will recognize the changes.

Member

rnveach commented Sep 4, 2017

@akurth you don't need to close and recreate a brand new PR to make changes.
All you need to do is amend your previous commit and force push it to the server and github will recognize the changes.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Sep 4, 2017

Member

TC problem is not related, will be fixed after rebase

Member

romani commented Sep 4, 2017

TC problem is not related, will be fixed after rebase

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 4, 2017

Codecov Report

Merging #5068 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5068   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         294     294           
  Lines       15984   15984           
  Branches     3621    3621           
======================================
  Hits        15984   15984

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 546bae1...489e53b. Read the comment docs.

codecov-io commented Sep 4, 2017

Codecov Report

Merging #5068 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5068   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         294     294           
  Lines       15984   15984           
  Branches     3621    3621           
======================================
  Hits        15984   15984

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 546bae1...489e53b. Read the comment docs.

romani added a commit that referenced this pull request Sep 4, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Sep 4, 2017

Member

commit had reference to old PR , I changed that manually, rebased, merged manually.

@akurth , thanks a lot, please change description to define what was bad.

Member

romani commented Sep 4, 2017

commit had reference to old PR , I changed that manually, rebased, merged manually.

@akurth , thanks a lot, please change description to define what was bad.

@romani romani closed this Sep 4, 2017

@akurth akurth deleted the akurth:pullrequest branch Sep 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment