Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Pull #5113: enabled eclipse compiler to flag unused exceptions #5113
@@ Coverage Diff @@ ## master #5113 +/- ## ====================================== Coverage 100% 100% ====================================== Files 296 296 Lines 16098 16098 Branches 3642 3642 ====================================== Hits 16098 16098
Along with the classpath being changed, the shell script has to be modified to include the test folder.
When doing so, it results in ~24 errors in master which I am also seeing locally inside Eclipse.
It looks like if we enable this in test, we would have to suppress these areas as they are just ways of testing.
changed the title from
Pull #XXX: flag unused exceptions in tests
Pull #5113: enabled eclipse compiler to flag unused exceptions
Sep 25, 2017
Description of eclipse preferences can be found at https://help.eclipse.org/mars/index.jsp?topic=%2Forg.eclipse.jdt.doc.user%2Freference%2Fpreferences%2Fjava%2Fcompiler%2Fref-preferences-errors-warnings.htm .
added a commit
this pull request
Sep 28, 2017
Travis failure is valid: