New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull #5363: add ANNOTATION_DEF to RequireThisCheck #5363

Merged
merged 1 commit into from Dec 23, 2017

Conversation

Projects
None yet
3 participants
@rnveach
Member

rnveach commented Dec 17, 2017

Identified at #5307 (comment) .
We had specifics to annotation interfaces, but we never used or collected them.

I will post regression soon.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Dec 17, 2017

Member

Regression: http://rveach.no-ip.org/checkstyle/regression/reports/145/
No differences.

target/site/cobertura/com.puppycrawl.tools.checkstyle.checks.coding.RequireThisCheck.html:<tr> <td class="numLineCover">&nbsp;880</td> <td class="nbHitsUncovered"><a title="Line 880: Conditional coverage 50% (1/2).">&nbsp;1499</a></td> <td class="src"><pre class="src"><span class="srcUncovered">&nbsp;<a title="Line 880: Conditional coverage 50% (1/2)."> <span class="keyword">if</span> (frame == <span class="keyword">null</span>) {</a></span></pre></td></tr>

frame can't be null now, so I'll remove this and redo regression.

Member

rnveach commented Dec 17, 2017

Regression: http://rveach.no-ip.org/checkstyle/regression/reports/145/
No differences.

target/site/cobertura/com.puppycrawl.tools.checkstyle.checks.coding.RequireThisCheck.html:<tr> <td class="numLineCover">&nbsp;880</td> <td class="nbHitsUncovered"><a title="Line 880: Conditional coverage 50% (1/2).">&nbsp;1499</a></td> <td class="src"><pre class="src"><span class="srcUncovered">&nbsp;<a title="Line 880: Conditional coverage 50% (1/2)."> <span class="keyword">if</span> (frame == <span class="keyword">null</span>) {</a></span></pre></td></tr>

frame can't be null now, so I'll remove this and redo regression.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 18, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@b02eed8). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #5363   +/-   ##
========================================
  Coverage          ?    100%           
========================================
  Files             ?     296           
  Lines             ?   16204           
  Branches          ?    3701           
========================================
  Hits              ?   16204           
  Misses            ?       0           
  Partials          ?       0
Impacted Files Coverage Δ
...ols/checkstyle/checks/coding/RequireThisCheck.java 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b02eed8...a828966. Read the comment docs.

codecov-io commented Dec 18, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@b02eed8). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #5363   +/-   ##
========================================
  Coverage          ?    100%           
========================================
  Files             ?     296           
  Lines             ?   16204           
  Branches          ?    3701           
========================================
  Hits              ?   16204           
  Misses            ?       0           
  Partials          ?       0
Impacted Files Coverage Δ
...ols/checkstyle/checks/coding/RequireThisCheck.java 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b02eed8...a828966. Read the comment docs.

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Dec 18, 2017

Member

http://rveach.no-ip.org/checkstyle/regression/reports/146/
New regression removing uncovered code. No differences.

Member

rnveach commented Dec 18, 2017

http://rveach.no-ip.org/checkstyle/regression/reports/146/
New regression removing uncovered code. No differences.

@rnveach rnveach requested a review from romani Dec 18, 2017

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Dec 23, 2017

Member

Please confirm that there is no extra uncovered or survived code in Check , https://github.com/checkstyle/checkstyle/blob/master/shippable.yml#L82 , this check is in exclude list.

If no new uncovered/survived - ok to merge

Member

romani commented Dec 23, 2017

Please confirm that there is no extra uncovered or survived code in Check , https://github.com/checkstyle/checkstyle/blob/master/shippable.yml#L82 , this check is in exclude list.

If no new uncovered/survived - ok to merge

@romani romani merged commit 0c20ec3 into checkstyle:master Dec 23, 2017

9 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
IDEA Inspections Pull Request (Checkstyle) TeamCity build finished
Details
Shippable Run 5785 status is SUCCESS.
Details
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/Distelli
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
wercker/build Wercker pipeline passed
Details

@rnveach rnveach deleted the rnveach:pr_5307_4 branch Dec 23, 2017

@romani romani changed the title from Pull #5363: added missing annotation token definition to Pull #5363: add ANNOTATION_DEF to RequireThisCheck Dec 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment