Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Pull #5364: changed RequireThis kept track of the frame being examined #5364
Identified at #5307 (comment) .
Here is proof:
Expecting a violation for
We are seeing alot of differences.
All other differences are changes in violation messages from
added a commit
this pull request
Dec 18, 2017
I'm not sure why this is still coming up when we disabled all input files.
@@ Coverage Diff @@ ## master #5364 +/- ## ====================================== Coverage 100% 100% ====================================== Files 296 296 Lines 16203 16208 +5 Branches 3700 3701 +1 ====================================== + Hits 16203 16208 +5
referenced this pull request
Dec 19, 2017
if this is kind of bug fix, why not to report it as usually do for bugs: "javac ... cat .... cat ... java -jar ...."
Why do not think new behavior is better ?
Updated first description with such example.
This change is correct.
I do think new behavior is better.
Please look over class structure more closely.
These 2 instances are un-related and so this fix will not reopen #2239 .
My change is related to not knowing we switched frames. Old processing thought we were inside an inner class of