Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: reset the test stream for each test #6557

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@Vampire
Copy link
Contributor

commented Mar 11, 2019

These streams are reused and without the reset call,
you are getting "Audit done." messages in assertion failures when
unexpected violations happen instead of the actual unexpected violation.
Resetting the streams fixes this.

This is a followup of #6511.

@rnveach rnveach requested a review from romani Mar 11, 2019

@romani

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

@Vampire , please replace 'minor' with 'Pull #6557' in commit message.

romani added a commit that referenced this pull request Mar 16, 2019

@romani

This comment has been minimized.

Copy link
Member

commented Mar 16, 2019

message changed, merged manually.

@romani romani closed this Mar 16, 2019

@rnveach rnveach added this to the 8.19 milestone Mar 16, 2019

@Vampire Vampire deleted the Vampire:reset-test-stream branch Mar 18, 2019

Vantuz added a commit to Vantuz/checkstyle that referenced this pull request Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.