Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: GeneratedJava14LexerTest depends on encoding, not on OS, so fix the assumption to represent this #6608

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@Vampire
Copy link
Contributor

commented Mar 25, 2019

If you set the encoding when running maven or if you run from IDE or if your
default encoding actually is UTF-8 even on Windows, the test could pretty well
run, so the assumption that is used to determine whether the test should be
skipped should represent this and not check for the OS.

@rnveach

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

@Vampire Does this PR go back to the issue we are discussing in #6560 where issue is with OutputStreamWriter with UTF_8 encoding specified?

@rnveach rnveach self-assigned this Apr 1, 2019

@Vampire Vampire force-pushed the Vampire:improve-test-assumption branch from 54b2c5c to 95a8764 Apr 8, 2019

@Vampire Vampire force-pushed the Vampire:improve-test-assumption branch from 95a8764 to 69e1fe4 Apr 8, 2019

@Vampire

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

@Vampire Does this PR go back to the issue we are discussing in #6560 where issue is with OutputStreamWriter with UTF_8 encoding specified?

Nah, not really.
Or well, it might be related.
Just a test I found is skipped more often than necessary, as it works fine whenever the default encoding is UTF-8 and not if not.
So testing for Windows is not really the right thing.

@rnveach

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

Seems our windows build still skips this, as it uses Cp1252 by default. https://ci.appveyor.com/project/Checkstyle/checkstyle/builds/23690254/job/d9afuvdf33ju7v80#L606
So CI isn't testing this on a windows system with UTF8 set.

This also explains a failure I saw in another PR related to this input file. #6645 (comment)

I am ok with this change. If #6560 is fixed, we should look back at this test and see if it shouldn't be skipped anymore.

@rnveach

rnveach approved these changes Apr 8, 2019

@rnveach rnveach assigned romani and unassigned rnveach Apr 8, 2019

@rnveach rnveach requested a review from romani Apr 8, 2019

romani added a commit that referenced this pull request Apr 17, 2019

Pull #6608: GeneratedJava14LexerTest depends on encoding, not on OS, …
…so fix the assumption to represent this
@romani

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

merged manually to fix commit message to refrence this PR as it has valuable discussion.

@romani romani closed this Apr 17, 2019

peterdemaeyer added a commit to peterdemaeyer/checkstyle that referenced this pull request Apr 27, 2019

Pull checkstyle#6608: GeneratedJava14LexerTest depends on encoding, n…
…ot on OS, so fix the assumption to represent this

peterdemaeyer added a commit to peterdemaeyer/checkstyle that referenced this pull request Apr 28, 2019

Pull checkstyle#6608: GeneratedJava14LexerTest depends on encoding, n…
…ot on OS, so fix the assumption to represent this

@Vampire Vampire deleted the Vampire:improve-test-assumption branch May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.