Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #6774: Add UnnecessarySemicolonInTryWithResourcesCheck #6799

Merged
merged 1 commit into from Jun 15, 2019

Conversation

strkkk
Copy link
Member

@strkkk strkkk commented Jun 3, 2019

@strkkk
Copy link
Member Author

strkkk commented Jun 6, 2019

@romani / @rnveach please take a look at this PR.

@romani romani self-assigned this Jun 12, 2019
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

report is good.

items to improve:

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last minor to improve:

src/xdocs/config_coding.xml Outdated Show resolved Hide resolved
src/xdocs/config_coding.xml Outdated Show resolved Hide resolved
src/xdocs/config_coding.xml Outdated Show resolved Hide resolved
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge.

@rnveach , please finalize.

@romani romani assigned rnveach and unassigned romani Jun 14, 2019
@rnveach rnveach merged commit 23cc42b into checkstyle:master Jun 15, 2019
@strkkk strkkk deleted the unn_semi_twr branch January 29, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants