diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfigurationWorkingCopy.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfigurationWorkingCopy.java index d51a2cacd..3835579bf 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfigurationWorkingCopy.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/projectconfig/ProjectConfigurationWorkingCopy.java @@ -352,11 +352,7 @@ private void storeToPersistence(ProjectConfigurationWorkingCopy config) // create or overwrite the .checkstyle file IProject project = config.getProject(); IFile file = project.getFile(ProjectConfigurationFactory.PROJECT_CONFIGURATION_FILE); - if (!file.exists()) { - file.create(pipeIn, true, null); - file.refreshLocal(IResource.DEPTH_INFINITE, null); - } else { - + if (file.exists()) { if (file.isReadOnly()) { ResourceAttributes attrs = ResourceAttributes.fromFile(file.getFullPath().toFile()); attrs.setReadOnly(true); @@ -364,6 +360,9 @@ private void storeToPersistence(ProjectConfigurationWorkingCopy config) } file.setContents(pipeIn, true, true, null); + } else { + file.create(pipeIn, true, null); + file.refreshLocal(IResource.DEPTH_INFINITE, null); } config.getLocalCheckConfigWorkingSet().store(); diff --git a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CheckstyleSetting.java b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CheckstyleSetting.java index bbb6d8a84..246ddf46c 100644 --- a/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CheckstyleSetting.java +++ b/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/transformer/CheckstyleSetting.java @@ -92,23 +92,23 @@ public void addSetting(final CheckstyleSetting setting) { String module; while (modit.hasNext()) { module = modit.next(); - if (!mCheckerModules.keySet().contains(module)) { - mCheckerModules.put(module, setting.getmCheckerModules().get(module)); - } else { + if (mCheckerModules.keySet().contains(module)) { final Iterator propit = setting.getmCheckerModules().get(module).keySet() .iterator(); String property; while (propit.hasNext()) { property = propit.next(); - if (!mCheckerModules.get(module).containsKey(property)) { - mCheckerModules.get(module).put(property, - setting.getmCheckerModules().get(module).get(property)); - } else { + if (mCheckerModules.get(module).containsKey(property)) { if (!mCheckerModules.get(module).get(property) .equals(setting.getmCheckerModules().get(module).get(property))) { } + } else { + mCheckerModules.get(module).put(property, + setting.getmCheckerModules().get(module).get(property)); } } + } else { + mCheckerModules.put(module, setting.getmCheckerModules().get(module)); } } @@ -116,23 +116,23 @@ public void addSetting(final CheckstyleSetting setting) { modit = setting.getmTreeWalkerModules().keySet().iterator(); while (modit.hasNext()) { module = modit.next(); - if (!mTreeWalkerModules.keySet().contains(module)) { - mTreeWalkerModules.put(module, setting.getmTreeWalkerModules().get(module)); - } else { + if (mTreeWalkerModules.keySet().contains(module)) { final Iterator propit = setting.getmTreeWalkerModules().get(module).keySet() .iterator(); String property; while (propit.hasNext()) { property = propit.next(); - if (!mTreeWalkerModules.get(module).containsKey(property)) { - mTreeWalkerModules.get(module).put(property, - setting.getmTreeWalkerModules().get(module).get(property)); - } else { + if (mTreeWalkerModules.get(module).containsKey(property)) { if (!mTreeWalkerModules.get(module).get(property) .equals(setting.getmTreeWalkerModules().get(module).get(property))) { } + } else { + mTreeWalkerModules.get(module).put(property, + setting.getmTreeWalkerModules().get(module).get(property)); } } + } else { + mTreeWalkerModules.put(module, setting.getmTreeWalkerModules().get(module)); } } } diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/RuleConfigurationEditDialog.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/RuleConfigurationEditDialog.java index 166828e6a..516f8e107 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/RuleConfigurationEditDialog.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/RuleConfigurationEditDialog.java @@ -330,10 +330,10 @@ private void initialize() { this.setTitle( NLS.bind(Messages.RuleConfigurationEditDialog_titleRuleConfigEditor, mRule.getName())); - if (!mReadonly) { - this.setMessage(Messages.RuleConfigurationEditDialog_msgEditRuleConfig); - } else { + if (mReadonly) { this.setMessage(Messages.RuleConfigurationEditDialog_msgReadonlyModule); + } else { + this.setMessage(Messages.RuleConfigurationEditDialog_msgEditRuleConfig); } String comment = mRule.getComment(); diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetMultiCheck.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetMultiCheck.java index f8c27fde0..ae62c3257 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetMultiCheck.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/config/widgets/ConfigPropertyWidgetMultiCheck.java @@ -199,14 +199,14 @@ private class TokenLabelProvider extends LabelProvider { @Override public String getText(Object element) { String translation = null; - if (!mTranslateTokens) { - translation = "" + element; //$NON-NLS-1$ - } else { + if (mTranslateTokens) { try { translation = TOKEN_BUNDLE.getString((String) element); } catch (MissingResourceException ex) { translation = "" + element; //$NON-NLS-1$ } + } else { + translation = "" + element; //$NON-NLS-1$ } return translation; } diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/CheckstylePropertyPage.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/CheckstylePropertyPage.java index 4eee66dd8..820629fae 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/CheckstylePropertyPage.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/CheckstylePropertyPage.java @@ -628,10 +628,10 @@ public void checkStateChanged(CheckStateChangedEvent event) { Object element = event.getElement(); if (element instanceof IFilter) { IFilter filter = (IFilter) element; - if (!filter.isReadonly()) { - filter.setEnabled(event.getChecked()); - } else { + if (filter.isReadonly()) { event.getCheckable().setChecked(event.getElement(), true); + } else { + filter.setEnabled(event.getChecked()); } } } diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/PackageFilterEditor.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/PackageFilterEditor.java index bc5587fa9..e38b97b1f 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/PackageFilterEditor.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/properties/filter/PackageFilterEditor.java @@ -431,16 +431,15 @@ protected void computeResult() { List checked = Arrays.asList(mViewer.getCheckedElements()); - if (!mRecursivelyExcludeSubPackages) { - setResult(checked); - } else { - + if (mRecursivelyExcludeSubPackages) { List grayed = Arrays.asList(mViewer.getGrayedElements()); List pureChecked = new ArrayList<>(checked); pureChecked.removeAll(grayed); setResult(pureChecked); + } else { + setResult(checked); } } diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/DefaultComesLastQuickfix.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/DefaultComesLastQuickfix.java index cff4f0855..318a36318 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/DefaultComesLastQuickfix.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/coding/DefaultComesLastQuickfix.java @@ -65,10 +65,10 @@ public boolean visit(SwitchCase node) { for (int i = defaultStatementIndex + 1; i < switchStatement.statements().size(); i++) { ASTNode tmpNode = (ASTNode) switchStatement.statements().get(i); - if (!(tmpNode instanceof SwitchCase)) { - defaultCaseStatements.add(tmpNode); - } else { + if (tmpNode instanceof SwitchCase) { break; + } else { + defaultCaseStatements.add(tmpNode); } } diff --git a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/internal/CheckstyleMarkerFilter.java b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/internal/CheckstyleMarkerFilter.java index f7d66f81b..eeb0b6197 100644 --- a/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/internal/CheckstyleMarkerFilter.java +++ b/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/stats/views/internal/CheckstyleMarkerFilter.java @@ -134,12 +134,7 @@ public IMarker[] findMarkers(IProgressMonitor mon) throws CoreException { List unfiltered = Collections.emptyList(); - if (!isEnabled()) { - unfiltered = findCheckstyleMarkers( - new IResource[] { ResourcesPlugin.getWorkspace().getRoot() }, - IResource.DEPTH_INFINITE, mon); - } else { - + if (isEnabled()) { switch (getOnResource()) { case ON_ANY_RESOURCE: { unfiltered = findCheckstyleMarkers( @@ -169,6 +164,10 @@ public IMarker[] findMarkers(IProgressMonitor mon) throws CoreException { break; } } + } else { + unfiltered = findCheckstyleMarkers( + new IResource[] { ResourcesPlugin.getWorkspace().getRoot() }, + IResource.DEPTH_INFINITE, mon); } if (unfiltered == null) {