Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for local instance posts #657

Merged
merged 16 commits into from
Sep 7, 2024

Conversation

Steffo99
Copy link
Contributor

@Steffo99 Steffo99 commented Aug 20, 2024

A new platform feature is defined, @pleroma/local-only, which is marked as present only if the string akkoma or the string pleroma is found in the instance version string.

Note

The instance version string of the two is:

  • X.Y.Z (compatible; Akkoma M.N.O)
  • X.Y.Z (compatible; Pleroma M.N.O)

If this feature is supported, a new post visibility option is added to the post compose visibility selector, "Local instance", which sets the visibility to "local".

The post viewer is also updated accordingly; while local-only posts could already be seen previously, they didn't have anything written in the .extra-meta section, and didn't display a visibility icon.

The building icon has been selected as the symbol for "Local instance" posts, as it's already used in the main menu to denote the Local timeline.

@Steffo99

This comment was marked as resolved.

A new platform feature is defined, `@akkoma/local-only`, which is marked as present only if the string `akkoma` is found in the instance version string.

If this feature is supported, a new post visibility option is added to the post compose visibility selector, "Local instance", which sets the visibility to `"local"`.

The post viewer is also updated accordingly; while local-only posts could already be seen previously, they didn't have anything written in the `.extra-meta` section, and didn't display a visibility icon.

The `building` icon has been selected as the symbol for "Local instance" posts, as it's already used in the main menu to denote the Local timeline.
@Steffo99 Steffo99 force-pushed the feature/akkoma-local-only branch from a887388 to 67cce5b Compare August 20, 2024 17:03
@Steffo99

This comment was marked as resolved.

@cheeaun cheeaun added enhancement New feature or request akkoma labels Aug 21, 2024
@Steffo99
Copy link
Contributor Author

Added support for pleroma !

src/utils/supports.js Outdated Show resolved Hide resolved
src/locales/it-IT.po Outdated Show resolved Hide resolved
src/utils/supports.js Outdated Show resolved Hide resolved
@Steffo99
Copy link
Contributor Author

Steffo99 commented Sep 5, 2024

How would you like me to resolve merge conflicts in .po files?

@Steffo99 Steffo99 requested a review from cheeaun September 5, 2024 08:36
src/components/compose.jsx Outdated Show resolved Hide resolved
src/utils/supports.js Outdated Show resolved Hide resolved
src/components/status.jsx Outdated Show resolved Hide resolved
@cheeaun
Copy link
Owner

cheeaun commented Sep 5, 2024

How would you like me to resolve merge conflicts in .po files?

Yes please, else the merge is blocked.

@Steffo99
Copy link
Contributor Author

Steffo99 commented Sep 7, 2024

Reposting this here...


I don't have an account on Misskey to confirm it's available there (and I'm not even sure it's compatible with the Mastodon API in first place), but I had a Firefish instance, and I've had a test account on an Iceshrimp one, and there "Local" is an on-off toggle separate from visibility:

On Firefish and Iceshrimp

Visibility Direct messages Home timeline Public profile Local timeline Federated timeline
Public 🟢 🟢 🟢 🟢
Local Public 🔷 🔷 🔷 🔷
Unlisted 🟨 🟢
Local Unlisted 🔶 🔷
Followers 🟨 🟨
Local Followers 🔶 🔶
Direct 🤍 🤍
Local Direct 🧡 🧡
Emoji Meaning
🟢 Anybody can see
🔷 Anybody can see if they look on the server the post was made, even without an account, but not through federation (different from Pleroma/Akkoma!)
🟨 Followers and mentioned can see
🔶 Any followers of the poster or mentioned in the post on the same server of the poster can see
🤍 Mentioned can see
🧡 Mentioned on the same server of the poster can see
Not visible

@Steffo99
Copy link
Contributor Author

Steffo99 commented Sep 7, 2024

Not sure about Hometown either; I don't have any instances close to my bubble running it...

@Steffo99 Steffo99 requested a review from cheeaun September 7, 2024 01:18
src/utils/supports.js Outdated Show resolved Hide resolved
@cheeaun cheeaun merged commit b280088 into cheeaun:main Sep 7, 2024
3 checks passed
@graue
Copy link
Contributor

graue commented Sep 13, 2024

I'm on a Hometown server, and yes, it's an on-off toggle separate from visibility. It is the same in Mastodon Glitch. Would love to have support for this built into Phanpy; what would it require? @Steffo99

@Steffo99
Copy link
Contributor Author

Implementing the toggle shouldn't be difficult, but we'd need to know where to put it...

What do you think, @cheeaun?

@Steffo99
Copy link
Contributor Author

let's move the discussion to #784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
akkoma enhancement New feature or request pleroma
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants