Some beginning work into allowing extensible platforms #1

Merged
merged 17 commits into from Jul 29, 2011

Projects

None yet

2 participants

@zspencer
Contributor

I admit, I may have gone a little overboard with this, but now both the watir and the selenium drivers are plugins.

I'm trying to work out where exactly to go with the elements, as many elements have watir or selenium specific methods on the base element class. Could use the same type of strategy (elements are registered for a platform, and that element takes care of any fancy pants stuff)

but I'm not sure if that's quite how to head yet. Thoughts?

Owner
cheezy commented Jul 28, 2011

Zac,

Sorry I haven't been real responsive. I've had an incredibly busy week so far and haven't had time to focus on the gem at all. I hope to take a look at your code this evening. I should have a lot more time over the next few days and weekend.

-Cheezy

On Jul 27, 2011, at 2:29 PM, zspencer wrote:

I admit, I may have gone a little overboard with this, but now both the watir and the selenium drivers are plugins.

I'm trying to work out where exactly to go with the elements, as many elements have watir or selenium specific methods on the base element class. Could use the same type of strategy (elements are registered for a platform, and that element takes care of any fancy pants stuff)

but I'm not sure if that's quite how to head yet. Thoughts?

Reply to this email directly or view it on GitHub:
#1

@zspencer zspencer Merge github.com:cheezy/page-object
Conflicts:
	features/html/static_elements.html
	lib/page-object/platforms/selenium_element.rb
	lib/page-object/platforms/watir_element.rb
	lib/page-object/selenium_page_object.rb
c8589e7
@zspencer zspencer merged commit c8589e7 into cheezy:master Jul 29, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment