New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when counting total failed controls in json format #106

Merged
merged 1 commit into from Oct 12, 2016

Conversation

Projects
None yet
3 participants
@alexpop
Collaborator

alexpop commented Oct 12, 2016

total_failed only worked for json-min format. The current version was not working on Chef Visibility reporting.

@alexpop alexpop added the Type: Bug label Oct 12, 2016

@binamov binamov added the in progress label Oct 12, 2016

Fix bug when counting total failed controls in json format
Signed-off-by: Alex Pop <apop@chef.io>
@@ -47,7 +47,7 @@
default['audit']['fail_if_any_audits_failed'] = false
# inspec gem version to install(e.g. '1.1.0')
default['audit']['inspec_version'] = '1.1.0'
default['audit']['inspec_version'] = '1.2.0'

This comment has been minimized.

@chris-rock

chris-rock Oct 12, 2016

Collaborator

👍

@chris-rock chris-rock merged commit 7c81711 into master Oct 12, 2016

2 checks passed

DCO This commit has a DCO Signed-off-by
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chris-rock

This comment has been minimized.

Collaborator

chris-rock commented Oct 12, 2016

Thanks for finding and fixing the issue @alexpop!

@binamov binamov removed the in progress label Oct 12, 2016

@chris-rock chris-rock deleted the ap/json_count branch Oct 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment