New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert library resources to proper custom resources #107

Merged
merged 4 commits into from Oct 14, 2016

Conversation

Projects
None yet
2 participants
@lamont-granquist
Contributor

lamont-granquist commented Oct 14, 2016

library cookbooks are not a recommended cookbook pattern

see:

https://docs.chef.io/custom_resources_notes.html

and issues like this which are directly related to trying to
fight the resources DSL:

chef-boneyard/httpd#97

Signed-off-by: Lamont Granquist lamont@scriptkiddie.org

convert library resources to proper custom resources
library cookbooks are not a recommended cookbook pattern

see:

https://docs.chef.io/custom_resources_notes.html

and issues like this which are directly related to trying to
fight the resources DSL:

chef-boneyard/httpd#97

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

@iennae iennae added the in progress label Oct 14, 2016

add compat_resource cookbook as a dep
adds support back to chef 12.1 and allows the use of more recent
chef-client features as well

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
@lamont-granquist

This comment has been minimized.

Contributor

lamont-granquist commented Oct 14, 2016

bonus: added compat_resource cookbook dep

bump deps, berkshelf 3.3->5.0 in particular
some of these pessimistic constraints are doing more harm
than good.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
@lamont-granquist

This comment has been minimized.

Contributor

lamont-granquist commented Oct 14, 2016

bonus bonus: try using a version of berkshelf than is less than a year old

remove Encoding rubocop enforcement
this isn't necessary at all in ruby >= 2.0

https://github.com/bbatsov/rubocop/blob/ec3123fc3454b080e1100e35480c6466d1240fff/lib/rubocop/cop/style/encoding.rb#L6-L15

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
@lamont-granquist

This comment has been minimized.

Contributor

lamont-granquist commented Oct 14, 2016

bonus bonus bonus: the Encoding cop is from the ruby-1.8/1.9 era so remove that

@lamont-granquist

This comment has been minimized.

Contributor

lamont-granquist commented Oct 14, 2016

@tas50 @iennae okay i think i'm done now.

@iennae

This comment has been minimized.

Contributor

iennae commented Oct 14, 2016

Taking a look ..

@iennae iennae merged commit 779015b into master Oct 14, 2016

2 checks passed

DCO This commit has a DCO Signed-off-by
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@iennae iennae removed the in progress label Oct 14, 2016

@iennae iennae deleted the lcg/remove-library-providers branch Oct 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment