New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not hand over run context into reporter #133

Merged
merged 1 commit into from Oct 28, 2016

Conversation

Projects
None yet
3 participants
@chris-rock
Collaborator

chris-rock commented Oct 28, 2016

No description provided.

@binamov binamov added the in progress label Oct 28, 2016

files/default/audit_report.rb Outdated
def send_report(reporter, server, user)
Chef::Log.info "Reporting to #{reporter}"
# TODO: harmonize reporter interface
if reporter == 'chef-visibility'
Collector::ChefVisibility.new(entity_uuid, run_id, run_context.node.name).send_report
Collector::ChefVisibility.new(entity_uuid, run_id, gather_nodeinfo).send_report

This comment has been minimized.

@vjeffrey

vjeffrey Oct 28, 2016

Collaborator

i think only node name was being sent to viz, which is why the tests are complaining

@vjeffrey

This comment has been minimized.

Collaborator

vjeffrey commented Oct 28, 2016

🌟 🎉 👍 yay!!!!! viz tests are breaking cause it only expects the node name, but +:1: once that's fixed! :)

do not hand over run context into reporter
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>

@chris-rock chris-rock merged commit 94a50c8 into master Oct 28, 2016

2 checks passed

DCO This commit has a DCO Signed-off-by
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chris-rock chris-rock deleted the chris-rock/run_context branch Oct 28, 2016

@binamov binamov removed the in progress label Oct 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment