New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fetcher for chef-server-visibility and add chef-server-compliance collector #163

Merged
merged 2 commits into from Nov 23, 2016

Conversation

Projects
None yet
2 participants
@alexpop
Collaborator

alexpop commented Nov 17, 2016

Fixes #158

The chef-server fetcher is also using a different fetching URL when reporter chef-server-visibility is used.

I was also thinking to introduce replace the current chef-server fetcher with chef-server-compliance and possibly add a chef-server-automate reporter. In the interest of keeping this change small for now. I reverted the fetcher change.

Attributes and README are not fully updated. Waiting for 馃憤 before doing that.

@alexpop alexpop changed the title from Deprecate chef-server fetcher and collector to Replace collector with reporter and change fetcher for chef-server-visibility Nov 22, 2016

@srenatus

Maybe this could be made more readable by putting it into another method, but overall 馃憤

@alexpop

This comment has been minimized.

Show comment
Hide comment
@alexpop

alexpop Nov 23, 2016

Collaborator

Thanks Stephan, updated based on your feedback!
In the interest of getting the chef-server-visibility collector to work, merging this and will sync up with @chris-rock later regarding the collector deprecation.

Collaborator

alexpop commented Nov 23, 2016

Thanks Stephan, updated based on your feedback!
In the interest of getting the chef-server-visibility collector to work, merging this and will sync up with @chris-rock later regarding the collector deprecation.

@alexpop alexpop changed the title from Replace collector with reporter and change fetcher for chef-server-visibility to Change fetcher for chef-server-visibility Nov 23, 2016

alexpop added some commits Nov 17, 2016

Fix chef-server-visibility collector and introduce chef-server-compli鈥
鈥nce

Signed-off-by: Alex Pop <apop@chef.io>
break url_prefix and remove the deprecation log message for now
Signed-off-by: Alex Pop <apop@chef.io>

@alexpop alexpop changed the title from Change fetcher for chef-server-visibility to Update fetcher for chef-server-visibility and add chef-server-compliance collector Nov 23, 2016

@alexpop alexpop merged commit ee20c93 into master Nov 23, 2016

2 checks passed

DCO This commit has a DCO Signed-off-by
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexpop alexpop removed the in progress label Nov 23, 2016

@chris-rock chris-rock deleted the ap/attributes-refactor branch Nov 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment