New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor reporting #214

Merged
merged 1 commit into from May 2, 2017

Conversation

Projects
None yet
2 participants
@chris-rock
Collaborator

chris-rock commented Apr 28, 2017

Description

  • splits up all reporters
  • harmonize reporter interface
  • implement webmock for all http reporter

Check List

refactor reporting
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>

@arlimus arlimus self-requested a review May 2, 2017

@arlimus

arlimus approved these changes May 2, 2017

Huge improvement to all the tests!
I really like the split of the reporters to be standalone. Great prep for the next step 👍

@arlimus arlimus merged commit e4e7fe8 into master May 2, 2017

2 checks passed

DCO This commit has a DCO Signed-off-by
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@arlimus arlimus deleted the chris-rock/refactor-reporter branch May 2, 2017

@arlimus arlimus removed the in progress label May 2, 2017

@arlimus

This comment has been minimized.

Contributor

arlimus commented May 2, 2017

Kudos Chris!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment