New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make chef_node attribute an opt-in feature #274

Merged
merged 1 commit into from Aug 30, 2017

Conversation

Projects
None yet
2 participants
@adamleff
Collaborator

adamleff commented Aug 30, 2017

To encourage good practices, and to not send data to the InSpec runner that is not needed by most users, the chef_node attribute that contains the Chef node object hash will only be sent if the "chef_node_attribute_enabled" audit attribute is set to true

Make chef_node attribute an opt-in feature
To encourage good practices, and to not send data to the InSpec runner
that is not needed by most users, the `chef_node` attribute that contains
the Chef node object hash will only be sent if the "chef_node_attribute_enabled"
audit attribute is set to `true`

Signed-off-by: Adam Leff <adam@leff.co>

@adamleff adamleff requested a review from arlimus Aug 30, 2017

@arlimus

Fantastic change thank you @adamleff !!

Fully agree with the direction. Exposing it by default opens too broad of a door. Let's be explicit about when we want it to expose this information and when it's not needed.

Thank you!!

@arlimus arlimus merged commit 9955e3b into master Aug 30, 2017

2 checks passed

DCO This commit has a DCO Signed-off-by
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@arlimus arlimus deleted the adamleff/chef_node-off-by-default branch Aug 30, 2017

@arlimus arlimus removed the in progress label Aug 30, 2017

@adamleff

This comment has been minimized.

Collaborator

adamleff commented Aug 31, 2017

While it did not make it into the code, let it be known for posterity reasons that the if statement on the following line is referred to as "The Hedgpeth if Statement":

9955e3b#diff-ac3f30b2c66fd1ec1b818a9707a4066dR36

Thank you @mhedgpeth for being passionate about the community doing "the right thing." 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment