New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle '@' in username when grabbing compliance profiles #280

Merged
merged 1 commit into from Sep 27, 2017

Conversation

Projects
None yet
5 participants
@kevinreedy
Contributor

kevinreedy commented Sep 19, 2017

Signed-off-by: Kevin Reedykreedy@chef.io

Description

When an Automate user has an @ in their username (like in LDAP or SAML), the profile URL to fetch is incorrect. It is currently resolving to https://chefserver.example.com/compliance/organizations/acme/owners/example.com/compliance/cis-windows2012r2-level1-memberserver/tar instead of https://chefserver.example.com/compliance/organizations/acme/owners/First.Last@example.com/compliance/cis-windows2012r2-level1-memberserver/tar for example.

I went to add new tests, but am confused by the current ones in https://github.com/chef-cookbooks/audit/blob/master/spec/unit/report/fetcher_spec.rb#L33-L37. I'd love to pair with someone Wednesday or early next week on the tests.

Issues Resolved

https://getchef.zendesk.com/agent/tickets/16346
https://chefio.atlassian.net/browse/TRI-549
https://chefio.atlassian.net/browse/BUG-439

Check List

@mivok mivok added the in progress label Sep 19, 2017

@arlimus

This comment has been minimized.

Contributor

arlimus commented Sep 20, 2017

@chris-rock

That makes sense @kevinreedy

@chris-rock

This comment has been minimized.

Collaborator

chris-rock commented Sep 20, 2017

@jerryaldrichiii jerryaldrichiii self-assigned this Sep 26, 2017

Handle '@' in username when grabbing compliance profiles
Signed-off-by: Kevin Reedy <kreedy@chef.io>
@kevinreedy

This comment has been minimized.

Contributor

kevinreedy commented Sep 26, 2017

Fixed DCO

@arlimus

Thank you @kevinreedy !!

@arlimus arlimus merged commit 8ccfccb into chef-cookbooks:master Sep 27, 2017

2 checks passed

DCO This commit has a DCO Signed-off-by
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@arlimus arlimus removed the in progress label Sep 27, 2017

arlimus added a commit that referenced this pull request Sep 27, 2017

arlimus added a commit that referenced this pull request Sep 27, 2017

simplify profile url code
As contributed #280

Signed-off-by: Dominik Richter <dominik.richter@gmail.com>

@arlimus arlimus referenced this pull request Sep 27, 2017

Merged

simplify profile url code #284

adamleff added a commit that referenced this pull request Sep 27, 2017

simplify profile url code (#284)
As contributed #280

Signed-off-by: Dominik Richter <dominik.richter@gmail.com>

miah added a commit to miah/audit that referenced this pull request Apr 11, 2018

miah added a commit to miah/audit that referenced this pull request Apr 11, 2018

simplify profile url code (chef-cookbooks#284)
As contributed chef-cookbooks#280

Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment