New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include handler in exception handlers as well as report handlers #290

Merged
merged 2 commits into from Dec 1, 2017

Conversation

Projects
None yet
4 participants
@drrk
Contributor

drrk commented Oct 16, 2017

Description

Run audits on CCR fail.

Issues Resolved

Fixes #289

Check List

Include handler in exception handlers as well as report handlers
Signed-off-by: Kimball Johnson <kj@chef.io>

@mivok mivok added the in progress label Oct 16, 2017

@adamleff

adamleff approved these changes Oct 16, 2017 edited

This seems like a reasonable change to me. It could probably use a bit of manual testing to confirm expected behavior.

Only drawback is if the CCR failed during the actual audit cookbook itself (i.e. installing the inspec gem), the errors generated by the handler failure may noisily shadow the actual error that caused the handler to fail to work properly in the first place (i.e. the gem failure will be many many many lines north of the handler failure that would be generated if inspec wasn't present on the system). However, it would be no less broken (and no additional data lost) as compared to the current state of affairs.

@chris-rock chris-rock requested a review from chef-cookbooks/audit-cookbook-maintainers as a code owner Dec 1, 2017

@chris-rock

While I think this should really be fixed in Chef client by the introduction of a new audit_handlers concept, this is a good temporary solution.

@chris-rock chris-rock merged commit 0039bfe into chef-cookbooks:master Dec 1, 2017

2 checks passed

DCO This is a merge commit and allowed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

miah added a commit to miah/audit that referenced this pull request Apr 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment