Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send end_time as utc RFC3339 #292

Merged
merged 1 commit into from Nov 9, 2017

Conversation

Projects
None yet
3 participants
@alexpop
Copy link
Contributor

alexpop commented Nov 6, 2017

Signed-off-by: Alex Pop apop@chef.io

Send end_time as utc RFC3339
Signed-off-by: Alex Pop <apop@chef.io>
@adamleff
Copy link
Contributor

adamleff left a comment

This feels like a breaking change. Have we validated that this change works with existing versions of Automate as well as the new version of Automate under active development?

@alexpop

This comment has been minimized.

Copy link
Contributor Author

alexpop commented Nov 8, 2017

Yes, tested that. We time parse it as time.RFC3339 and it works fine with both
2016-07-19T19:19:19+01:00 and 2016-07-19T18:19:19Z formats

@chris-rock
Copy link
Contributor

chris-rock left a comment

Thank you @alexpop

@chris-rock chris-rock merged commit 0f3fcff into master Nov 9, 2017

2 checks passed

DCO This commit has a DCO Signed-off-by
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chris-rock chris-rock deleted the ap/end_time_rfc3389_utc branch Nov 9, 2017

miah added a commit to miah/audit that referenced this pull request Apr 11, 2018

Send end_time as utc RFC3339 (chef-cookbooks#292)
Signed-off-by: Alex Pop <apop@chef.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.