New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Audit cookbook to support ChefClient 14 #313

Merged
merged 3 commits into from Apr 19, 2018

Conversation

Projects
None yet
4 participants
@jquick
Contributor

jquick commented Apr 18, 2018

Signed-off-by: Jared Quick jquick@chef.io

Description

This fixes the resource version issue with ChefClient 14.

Issues Resolved

Fixes #312

Check List

@jquick jquick requested a review from chef-cookbooks/audit-cookbook-maintainers as a code owner Apr 18, 2018

Update Audit cookbook to support ChefClient14.
Signed-off-by: Jared Quick <jquick@chef.io>
@jerryaldrichiii

Looks good to me!

Update tests for Inspec 2.0 json changes.
Signed-off-by: Jared Quick <jquick@chef.io>
@jquick

This comment has been minimized.

Contributor

jquick commented Apr 19, 2018

Updated the tests here as json['controls'] was removed from the json report in inspec 2.0. Also bound kitchen-dokken to a working version. Newer versions do not allow the kitchen cache to be accessed in the validation stage.

@jquick

This comment has been minimized.

Contributor

jquick commented Apr 19, 2018

Tested on both 13/14 client versions.

@jquick

This comment has been minimized.

Contributor

jquick commented Apr 19, 2018

Should minor bump for this when released.

@chris-rock

Thank you @jquick

@jquick jquick merged commit a7ca7d2 into master Apr 19, 2018

2 checks passed

DCO This is a merge commit and allowed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jquick jquick deleted the jq/fix_chefclient14 branch Apr 19, 2018

@adamleff adamleff removed the in progress label Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment