Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat_resource is no longer supported #316

Merged
merged 1 commit into from May 7, 2018

Conversation

Projects
None yet
4 participants
@lamont-granquist
Copy link
Contributor

lamont-granquist commented May 4, 2018

this is breaking our internal use of the audit cookbook on chef-13
somehow by pulling this in as a dep.

this declares it drops support for chef <= 12.19 because that's the
last rev of chef-client that was pulled into compat_resource, i
don't know which features might specifically be getting used in
order to produce a lower threshold. 12.20.x is over a year old
though and that is still a wider window than our declared 6
month support window for cookbooks (and the EOL of the entire
Chef 12 line is imminently happening).

https://github.com/chef/chef-rfc/blob/master/rfc092-dependency-update-cadence.md#cookbook-and-ecosystem-tooling-support

compat_resource is no longer supported
this is breaking our internal use of the audit cookbook on chef-13
somehow by pulling this in as a dep.

this declares it drops support for chef <= 12.19 because that's the
last rev of chef-client that was pulled into compat_resource, i
don't know which features might specifically be getting used in
order to produce a lower threshold.  12.20.x is over a year old
though and that is still a wider window than our declared 6
month support window for cookbooks (and the EOL of the entire
Chef 12 line is imminently happening).

https://github.com/chef/chef-rfc/blob/master/rfc092-dependency-update-cadence.md#cookbook-and-ecosystem-tooling-support

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>

@lamont-granquist lamont-granquist requested a review from chef-cookbooks/audit-cookbook-team as a code owner May 4, 2018

@adamleff adamleff added the in progress label May 4, 2018

@tas50

This comment has been minimized.

Copy link
Member

tas50 commented May 4, 2018

@jquick Any idea what we were actually using compat_resource for in this cookbook?

@lamont-granquist

This comment has been minimized.

Copy link
Contributor Author

lamont-granquist commented May 4, 2018

a083c5b#diff-9fd042d4cd1e8f82894bbd7dffb313ec

i submitted the PR to add it, no idea why. there also wouldn't be any tracking of subsequent commits since that one which starting using features from compat_resource that were not in 12.5.1.

@tas50

This comment has been minimized.

Copy link
Member

tas50 commented May 4, 2018

We should just set the dep to 12.7 and be done with it then since that's why action_class started working all the way.

@jquick

jquick approved these changes May 7, 2018

Copy link
Contributor

jquick left a comment

Sounds good to me, seems to be working as expected without that dependency.

@tas50 tas50 merged commit faa746f into master May 7, 2018

2 checks passed

DCO This commit has a DCO Signed-off-by
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@adamleff adamleff removed the in progress label May 7, 2018

@tas50 tas50 deleted the lcg/remove-compat-resource branch May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.