Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch format to reporter #336

Merged
merged 2 commits into from Sep 18, 2018

Conversation

Projects
None yet
4 participants
@alexpop
Copy link
Contributor

alexpop commented Sep 18, 2018

Description

In prep for the inspec 3.0 release which deprecates format.

Switch to using reporter in prep for inspec 3.0 release when format i…
…s being deprecated

Signed-off-by: Alex Pop <apop@chef.io>

@alexpop alexpop requested a review from chef-cookbooks/audit-cookbook-team as a code owner Sep 18, 2018

@vjeffrey
Copy link
Collaborator

vjeffrey left a comment

thank you!

opts = {
'report' => true,
'format' => format,
'format' => reporter, # For compatibility with older versions of inspec. This line can be removed from Q2 2019

This comment has been minimized.

Copy link
@jerryaldrichiii

jerryaldrichiii Sep 18, 2018

Contributor

On the InSpec side of these we try to phrase these as TODO: so we can search for it easily.

Could we do that here or open an issue? I won't hold up the PR over it.

@alexpop

This comment has been minimized.

Copy link
Contributor Author

alexpop commented Sep 18, 2018

TODO makes sense Jerry, pushed another commit to add it.
Thank you for the reviews.

@jquick

jquick approved these changes Sep 18, 2018

Copy link
Contributor

jquick left a comment

Love it!

Add TODO
Signed-off-by: Alex Pop <apop@chef.io>

@alexpop alexpop force-pushed the ap/reporter branch from dcd4409 to eadb877 Sep 18, 2018

@alexpop alexpop merged commit 16ef94a into master Sep 18, 2018

2 checks passed

DCO This commit has a DCO Signed-off-by
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.