New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile name validation and unit tests #36

Merged
merged 3 commits into from May 3, 2016

Conversation

Projects
None yet
3 participants
@alexpop
Collaborator

alexpop commented Apr 27, 2016

Give a more descriptive error message if the profile name provided is invalid:

RuntimeError
------------
Invalid profile name 'mylinux'. Must contain /, e.g. 'john/ssh'

Adds unit tests for this case, but also for correct profile names

add profile name validation
and chefspec tests to cover runlist and success/failure

@iennae iennae added the in progress label Apr 27, 2016

@alexpop

This comment has been minimized.

Collaborator

alexpop commented Apr 27, 2016

@andy-dufour raising the bar with the tests :)

@chris-rock chris-rock merged commit d02c9ab into master May 3, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@chris-rock chris-rock deleted the ap/check-and-tests branch May 3, 2016

@iennae iennae removed the in progress label May 3, 2016

@chris-rock

This comment has been minimized.

Collaborator

chris-rock commented May 3, 2016

Thanks @alexpop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment