New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding with_http_rescue method call back in #61

Merged
merged 1 commit into from Jun 9, 2016

Conversation

Projects
None yet
3 participants
@jeremymv2
Contributor

jeremymv2 commented Jun 9, 2016

Description

This change resolves the following error from version 0.10.0 of the cookbook:

 NoMethodError
    -------------
    undefined method `code' for #<Tempfile:/tmp/compliance-profile20160609-2220-117sw6.tgz>

    Cookbook Trace:
    ---------------
    /var/chef/cache/cookbooks/audit/libraries/helper.rb:40:in `with_http_rescue'
    /var/chef/cache/cookbooks/audit/libraries/profile.rb:93:in `block (2 levels) in <class:ComplianceProfile>'
    /var/chef/cache/cookbooks/audit/libraries/profile.rb:54:in `block in <class:ComplianceProfile>'

It also re-adds the with_http_rescue method call for proper error handling when communicating with chef_gate on the Chef Server. It's very beneficial to have this error handling.

The with_http_rescue method was removed in between version 0.10.0 and 0.11.0 of the cookbook.

This change has been tested on both Linux Ubuntu 14.04 and Windows 2012R2.

Issues Resolved

Adds back in error handling for the code path that fetches profiles through the Chef Server.

Check List

@iennae iennae added the in progress label Jun 9, 2016

@smurawski smurawski merged commit 515a8d7 into chef-cookbooks:master Jun 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@iennae iennae removed the in progress label Jun 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment