New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog generator task to be native rake task #74

Merged
merged 2 commits into from Aug 15, 2016

Conversation

Projects
None yet
3 participants
@brentm5
Contributor

brentm5 commented Aug 12, 2016

Description

This updates the rake task for generating the CHANGELOG documentation so that it includes the new link as well as dynamically gets the current version number.

Issues Resolved

It solves an issue where the changelog Full Changelog link is generated wrong.

Check List

brentm5 added some commits Aug 12, 2016

Update changelog generator task to be native rake task
- Fix issue with full changelog link is generated wrong
- Move to a more modular rake task definition pattern
- Generate updated Changelog to fix links
@chris-rock

This comment has been minimized.

Collaborator

chris-rock commented Aug 15, 2016

Great, thanks for the improvement @brentm5

@chef-supermarket

This comment has been minimized.

chef-supermarket commented Aug 15, 2016

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

GitHub Users Who Are Not Authorized To Contribute

The following GitHub users do not appear to have signed a CLA:

Please sign the CLA here.

@chris-rock

This comment has been minimized.

Collaborator

chris-rock commented Aug 15, 2016

@brentm5 Have you signed the Chef CLA? I would be happy to merge it, once it is signed

@brentm5

This comment has been minimized.

Contributor

brentm5 commented Aug 15, 2016

Yeah I recently changed my usename from bigbam505 to brentm5. Looks like supermarket might have had the old account so I went ahead and reauthorized with the new account. I assume thats the issue anyway.

@chef-supermarket

This comment has been minimized.

chef-supermarket commented Aug 15, 2016

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

@chris-rock

This comment has been minimized.

Collaborator

chris-rock commented Aug 15, 2016

@brentm5 Awesome!

@chris-rock chris-rock merged commit a0134c4 into chef-cookbooks:master Aug 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@brentm5 brentm5 deleted the brentm5:bm-polish-changelog branch Aug 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment